2023-09-12 13:10:09

by Iuliana Prodan

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

On 9/12/2023 2:30 PM, Marco Felsch wrote:
> Hi Iuliana,
>
> On 23-09-12, Iuliana Prodan (OSS) wrote:
>> From: Iuliana Prodan <[email protected]>
>>
>> Add the reserve-memory nodes used by DSP when the rpmsg
>> feature is enabled.
>> These can be later used in a dsp node, like:
>> dsp: dsp@3b6e8000 {
>> compatible = "fsl,imx8mp-dsp";
>> reg = <0x3b6e8000 0x88000>;
>> mbox-names = "tx0", "rx0", "rxdb0";
>> mboxes = <&mu2 2 0>, <&mu2 2 1>,
>> <&mu2 3 0>, <&mu2 3 1>;
>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
>> <&dsp_vdev0vring1>, <&dsp_reserved>;
>> status = "okay";
>> };
>>
>> Signed-off-by: Iuliana Prodan <[email protected]>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> index cc406bb338fe..eedc1921af62 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> @@ -210,6 +210,18 @@
>> dsp_reserved: dsp@92400000 {
>> reg = <0 0x92400000 0 0x2000000>;
>> no-map;
> This seems broken.


You're right.
Already answered to this here:
https://www.mail-archive.com/[email protected]/msg2558691.html

Thanks,
Iulia

> Regards,
> Marco
>
>> + dsp_vdev0vring0: vdev0vring0@942f0000 {
>> + reg = <0 0x942f0000 0 0x8000>;
>> + no-map;
>> + };
>> + dsp_vdev0vring1: vdev0vring1@942f8000 {
>> + reg = <0 0x942f8000 0 0x8000>;
>> + no-map;
>> + };
>> + dsp_vdev0buffer: vdev0buffer@94300000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0 0x94300000 0 0x100000>;
>> + no-map;
>> };
>> };
>>
>> --
>> 2.17.1
>>
>>
>>