2024-02-27 08:20:33

by Jiapeng Chong

Subject: [PATCH] bdev: make blockdev_mnt static

The blockdev_mnt are not used outside the file bdev.c, so the modification
is defined as static.

block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8341
Signed-off-by: Jiapeng Chong <[email protected]>
---
block/bdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bdev.c b/block/bdev.c
index e7adaaf1c219..ca1c12c1189e 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -374,7 +374,7 @@ static struct file_system_type bd_type = {
};

struct super_block *blockdev_superblock __ro_after_init;
-struct vfsmount *blockdev_mnt __ro_after_init;
+static struct vfsmount *blockdev_mnt __ro_after_init;
EXPORT_SYMBOL_GPL(blockdev_superblock);

void __init bdev_cache_init(void)
--
2.20.1.7.g153144c

2024-02-28 14:21:56

by Jens Axboe

Subject: Re: [PATCH] bdev: make blockdev_mnt static

On 2/27/24 1:19 AM, Jiapeng Chong wrote:
> The blockdev_mnt are not used outside the file bdev.c, so the modification
> is defined as static.
>
> block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?

What is this against?

--
Jens Axboe

2024-02-28 17:02:46

by Christoph Hellwig

Subject: Re: [PATCH] bdev: make blockdev_mnt static

On Tue, Feb 27, 2024 at 04:19:58PM +0800, Jiapeng Chong wrote:
> The blockdev_mnt are not used outside the file bdev.c, so the modification
> is defined as static.
>
> block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?
>

The patch looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8341

But I don't think kernel commit should close random bugzillas?