On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote:
> On 26. Mar 2021, at 10:36, Paolo Abeni <[email protected]> wrote:
> > One thing you can do to simplifies the maintainer's life, would be post
> > a v2 with the correct tag (and ev. obsolete this patch in patchwork).
>
> I am quite new to contribute patches to the kernel so I am not sure
> how I would “obsolete” this patch and make a v2. If you can give me
> some pointers I am happy to do so.
Well, I actually gave you a bad advice about fiddling with patchwork.
The autoritative documentation:
Documentation/networking/netdev-FAQ.rst
(inside the kernel tree) suggests to avoid it.
Just posting a v2 will suffice.
Thanks!
Paolo
Friendly ping…
As this missing change was most likely an oversight in the original commit I do think it should go into 5.12 and subsequently stable as well. That’s also the reason why I didn’t send a v2 and changed the commit message / subject for the patch. For me it clearly is a bug and not a new feature.
Thanks
Norman
> On 26. Mar 2021, at 13:22, Paolo Abeni <[email protected]> wrote:
>
> On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote:
>> On 26. Mar 2021, at 10:36, Paolo Abeni <[email protected]> wrote:
>>> One thing you can do to simplifies the maintainer's life, would be post
>>> a v2 with the correct tag (and ev. obsolete this patch in patchwork).
>>
>> I am quite new to contribute patches to the kernel so I am not sure
>> how I would “obsolete” this patch and make a v2. If you can give me
>> some pointers I am happy to do so.
>
> Well, I actually gave you a bad advice about fiddling with patchwork.
>
> The autoritative documentation:
>
> Documentation/networking/netdev-FAQ.rst
>
> (inside the kernel tree) suggests to avoid it.
>
> Just posting a v2 will suffice.
>
> Thanks!
>
> Paolo
>
On Wed, 2021-03-31 at 15:10 +0200, Norman Maurer wrote:
> As this missing change was most likely an oversight in the original
> commit I do think it should go into 5.12 and subsequently stable as
> well. That’s also the reason why I didn’t send a v2 and changed the
> commit message / subject for the patch. For me it clearly is a bug
> and not a new feature.
I have no strong opinion against that (sorry, I hoped that was clear in
my reply).
Please go ahead.
Thanks,
Paolo
On 3/31/21 7:10 AM, Norman Maurer wrote:
> Friendly ping…
>
> As this missing change was most likely an oversight in the original commit I do think it should go into 5.12 and subsequently stable as well. That’s also the reason why I didn’t send a v2 and changed the commit message / subject for the patch. For me it clearly is a bug and not a new feature.
>
>
I agree that it should be added to net
If you do not see it here:
https://patchwork.kernel.org/project/netdevbpf/list/
you need to re-send and clearly mark it as [PATCH net]. Make sure it has
a Fixes tag.
> On 1. Apr 2021, at 02:18, David Ahern <[email protected]> wrote:
>
> On 3/31/21 7:10 AM, Norman Maurer wrote:
>> Friendly ping…
>>
>> As this missing change was most likely an oversight in the original commit I do think it should go into 5.12 and subsequently stable as well. That’s also the reason why I didn’t send a v2 and changed the commit message / subject for the patch. For me it clearly is a bug and not a new feature.
>>
>>
>
> I agree that it should be added to net
>
> If you do not see it here:
> https://patchwork.kernel.org/project/netdevbpf/list/
>
> you need to re-send and clearly mark it as [PATCH net]. Make sure it has
> a Fixes tag.
>
Done: https://lore.kernel.org/netdev/[email protected]/
Thanks a lot of the review and help.
Bye
Norman