2023-01-04 13:00:30

by Shigeru Yoshida

Subject: [PATCH] fs/ntfs3: Fix error handling in ntfs_new_inode()

When memory allocation for mi->mrec fails, ntfs_new_inode() calls
iput(). iput() calls ni_write_inode() indirectly, it references
uninitialized mi->mrec, and this causes the kernel crash. This patch
fixes the issue by making the inode bad before calling iput().

Signed-off-by: Shigeru Yoshida <[email protected]>
---
fs/ntfs3/fsntfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
index 567563771bf8..7b93f2aeb6f6 100644
--- a/fs/ntfs3/fsntfs.c
+++ b/fs/ntfs3/fsntfs.c
@@ -1683,6 +1683,7 @@ struct ntfs_inode *ntfs_new_inode(struct ntfs_sb_info *sbi, CLST rno, bool dir)

out:
if (err) {
+ _ntfs_bad_inode(inode);
iput(inode);
ni = ERR_PTR(err);
}
--
2.39.0

2023-01-13 09:59:34

by Konstantin Komarov

Subject: Re: [PATCH] fs/ntfs3: Fix error handling in ntfs_new_inode()

On 04.01.2023 16:39, Shigeru Yoshida wrote:
> When memory allocation for mi->mrec fails, ntfs_new_inode() calls
> iput(). iput() calls ni_write_inode() indirectly, it references
> uninitialized mi->mrec, and this causes the kernel crash. This patch
> fixes the issue by making the inode bad before calling iput().
>
> Signed-off-by: Shigeru Yoshida <[email protected]>
> ---
> fs/ntfs3/fsntfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> index 567563771bf8..7b93f2aeb6f6 100644
> --- a/fs/ntfs3/fsntfs.c
> +++ b/fs/ntfs3/fsntfs.c
> @@ -1683,6 +1683,7 @@ struct ntfs_inode *ntfs_new_inode(struct ntfs_sb_info *sbi, CLST rno, bool dir)
>
> out:
> if (err) {
> + _ntfs_bad_inode(inode);
> iput(inode);
> ni = ERR_PTR(err);
> }

Hello.

This bug have been already fixed by Ye Bin
(https://lore.kernel.org/lkml/[email protected]/).

* Thanks for your work.

2023-01-16 09:29:42

by Shigeru Yoshida

Subject: Re: [PATCH] fs/ntfs3: Fix error handling in ntfs_new_inode()

Hi,

On Fri, Jan 13, 2023 at 01:44:48PM +0400, Konstantin Komarov wrote:
> On 04.01.2023 16:39, Shigeru Yoshida wrote:
> > When memory allocation for mi->mrec fails, ntfs_new_inode() calls
> > iput(). iput() calls ni_write_inode() indirectly, it references
> > uninitialized mi->mrec, and this causes the kernel crash. This patch
> > fixes the issue by making the inode bad before calling iput().
> >
> > Signed-off-by: Shigeru Yoshida <[email protected]>
> > ---
> > fs/ntfs3/fsntfs.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> > index 567563771bf8..7b93f2aeb6f6 100644
> > --- a/fs/ntfs3/fsntfs.c
> > +++ b/fs/ntfs3/fsntfs.c
> > @@ -1683,6 +1683,7 @@ struct ntfs_inode *ntfs_new_inode(struct ntfs_sb_info *sbi, CLST rno, bool dir)
> > out:
> > if (err) {
> > + _ntfs_bad_inode(inode);
> > iput(inode);
> > ni = ERR_PTR(err);
> > }
>
> Hello.
>
> This bug have been already fixed by Ye Bin (https://lore.kernel.org/lkml/[email protected]/).

I've missed the fix you mentioned.
Thank you so much for your reply!

Shigeru

>
> * Thanks for your work.
>