2023-01-04 15:22:57

by Lizhe

[permalink] [raw]
Subject: [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART

in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()

Signed-off-by: lizhe <[email protected]>
Acked-by: Jiri Slaby <[email protected]>
Acked-by: Ilpo Järvinen<[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
---
drivers/tty/serial/fsl_linflexuart.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
return PTR_ERR(sport->membase);

sport->dev = &pdev->dev;
- sport->type = PORT_LINFLEXUART;
sport->iotype = UPIO_MEM;
sport->irq = platform_get_irq(pdev, 0);
sport->ops = &linflex_pops;
--
2.17.1


2023-01-04 15:31:02

by Ilpo Järvinen

[permalink] [raw]
Subject: Re: [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART

On Wed, 4 Jan 2023, lizhe wrote:

> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
>
> Signed-off-by: lizhe <[email protected]>

> Acked-by: Jiri Slaby <[email protected]>
> Acked-by: Ilpo J?rvinen<[email protected]>

Eh, you're not supposed to invent these Acked-by tags yourself. Don't add
any tags besides your own unless somebody explicitly gives them to you in
a reply!

And the subject was supposed to be (as per Jiri's recommendation):
serial: linflexuart: remove redundant uart type assignment

You also didn't include the history of what was changed in v3.

--
i.