2020-05-18 01:35:33

by Haiwei Li

Subject: [PATCH] KVM: Fix the indentation to match coding style

From: Haiwei Li <[email protected]>

There is a bad indentation in next&queue branch. The patch looks like
fixes nothing though it fixes the indentation.

Before fixing:

if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
kvm_skip_emulated_instruction(vcpu);
ret = EXIT_FASTPATH_EXIT_HANDLED;
}
break;
case MSR_IA32_TSCDEADLINE:

After fixing:

if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
kvm_skip_emulated_instruction(vcpu);
ret = EXIT_FASTPATH_EXIT_HANDLED;
}
break;
case MSR_IA32_TSCDEADLINE:


Signed-off-by: Haiwei Li <[email protected]>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 471fccf..446f747 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
kvm_vcpu *vcpu)
if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
kvm_skip_emulated_instruction(vcpu);
ret = EXIT_FASTPATH_EXIT_HANDLED;
- }
+ }
break;
case MSR_IA32_TSCDEADLINE:
data = kvm_read_edx_eax(vcpu);
--
1.8.3.1

2020-05-18 03:13:19

by Wanpeng Li

Subject: Re: [PATCH] KVM: Fix the indentation to match coding style

On Mon, 18 May 2020 at 09:32, Haiwei Li <[email protected]> wrote:
>
> From: Haiwei Li <[email protected]>
>
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
>
> Before fixing:
>
> if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
> kvm_skip_emulated_instruction(vcpu);
> ret = EXIT_FASTPATH_EXIT_HANDLED;
> }
> break;
> case MSR_IA32_TSCDEADLINE:
>
> After fixing:
>
> if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
> kvm_skip_emulated_instruction(vcpu);
> ret = EXIT_FASTPATH_EXIT_HANDLED;
> }
> break;
> case MSR_IA32_TSCDEADLINE:
>

Reviewed-by: Wanpeng Li <[email protected]>

>
> Signed-off-by: Haiwei Li <[email protected]>
> ---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
> if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
> kvm_skip_emulated_instruction(vcpu);
> ret = EXIT_FASTPATH_EXIT_HANDLED;
> - }
> + }
> break;
> case MSR_IA32_TSCDEADLINE:
> data = kvm_read_edx_eax(vcpu);
> --
> 1.8.3.1

2020-05-18 10:59:07

by Paolo Bonzini

Subject: Re: [PATCH] KVM: Fix the indentation to match coding style

On 18/05/20 03:31, Haiwei Li wrote:
> From: Haiwei Li <[email protected]>
>
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
>
> Before fixing:
>
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
>
> After fixing:
>
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
>
>
> Signed-off-by: Haiwei Li <[email protected]>
> ---
>  arch/x86/kvm/x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
>                 data = kvm_read_edx_eax(vcpu);
> --
> 1.8.3.1
>

Queued, thanks.

Paolo