2022-05-18 03:52:55

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: Tree for May 17 (drivers/nvme/host/fc.o)



On 5/17/22 02:41, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20220516:
>

on i386 or x86_64: (multiple builds)

ld: drivers/nvme/host/fc.o: in function `nvme_fc_io_getuuid':
/work/lnx/next/linux-next-20220517/X64/../drivers/nvme/host/fc.c:1914: undefined reference to `blkcg_get_fc_appid'


Full randconfig file is attached.

--
~Randy

Attachments:
config-r2850.gz (28.25 kB)

2022-05-18 05:30:23

by Christoph Hellwig

[permalink] [raw]
Subject: Re: linux-next: Tree for May 17 (drivers/nvme/host/fc.o)

The patch that adds nvme_fc_io_getuuid need something like this
folded in:

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index a11c69e681180..3c778bb0c2944 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -1911,7 +1911,9 @@ char *nvme_fc_io_getuuid(struct nvmefc_fcp_req *req)
struct nvme_fc_fcp_op *op = fcp_req_to_fcp_op(req);
struct request *rq = op->rq;

- return rq->bio ? blkcg_get_fc_appid(rq->bio) : NULL;
+ if (!IS_ENABLED(CONFIG_BLK_CGROUP_FC_APPID) || !rq->bio)
+ return NULL;
+ return blkcg_get_fc_appid(rq->bio);
}
EXPORT_SYMBOL_GPL(nvme_fc_io_getuuid);


2022-05-18 05:41:59

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: Tree for May 17 (drivers/nvme/host/fc.o)



On 5/17/22 21:57, Christoph Hellwig wrote:
> The patch that adds nvme_fc_io_getuuid need something like this
> folded in:
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index a11c69e681180..3c778bb0c2944 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -1911,7 +1911,9 @@ char *nvme_fc_io_getuuid(struct nvmefc_fcp_req *req)
> struct nvme_fc_fcp_op *op = fcp_req_to_fcp_op(req);
> struct request *rq = op->rq;
>
> - return rq->bio ? blkcg_get_fc_appid(rq->bio) : NULL;
> + if (!IS_ENABLED(CONFIG_BLK_CGROUP_FC_APPID) || !rq->bio)
> + return NULL;
> + return blkcg_get_fc_appid(rq->bio);
> }
> EXPORT_SYMBOL_GPL(nvme_fc_io_getuuid);
>

Thanks. You can add

Acked-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]>

to the patch.

--
~Randy

2022-10-19 14:10:00

by James Smart

[permalink] [raw]
Subject: Re: linux-next: Tree for May 17 (drivers/nvme/host/fc.o)

On 5/17/2022 10:21 PM, Randy Dunlap wrote:
>
>
> On 5/17/22 21:57, Christoph Hellwig wrote:
>> The patch that adds nvme_fc_io_getuuid need something like this
>> folded in:
>>
>> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
>> index a11c69e681180..3c778bb0c2944 100644
>> --- a/drivers/nvme/host/fc.c
>> +++ b/drivers/nvme/host/fc.c
>> @@ -1911,7 +1911,9 @@ char *nvme_fc_io_getuuid(struct nvmefc_fcp_req *req)
>> struct nvme_fc_fcp_op *op = fcp_req_to_fcp_op(req);
>> struct request *rq = op->rq;
>>
>> - return rq->bio ? blkcg_get_fc_appid(rq->bio) : NULL;
>> + if (!IS_ENABLED(CONFIG_BLK_CGROUP_FC_APPID) || !rq->bio)
>> + return NULL;
>> + return blkcg_get_fc_appid(rq->bio);
>> }
>> EXPORT_SYMBOL_GPL(nvme_fc_io_getuuid);
>>
>
> Thanks. You can add
>
> Acked-by: Randy Dunlap <[email protected]>
> Tested-by: Randy Dunlap <[email protected]>
>
> to the patch.
>

looks good

Reviewed-by: James Smart <[email protected]>

-- james