2022-08-12 12:04:30

by Martin Liška

Subject: [PATCH] perf: Print debuginfod queries if -v option is used

When ending a perf record session, the querying of a debuginfod
server can take quite some time. Inform a user about it when
-v options is used.

Signed-off-by: Martin Liska <[email protected]>
---
tools/perf/util/build-id.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index 0cc68cdd84c8..d1cfce0613ee 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -653,7 +653,9 @@ static char *build_id_cache__find_debug(const char *sbuild_id,

#ifdef HAVE_DEBUGINFOD_SUPPORT
if (realname == NULL) {
- debuginfod_client* c = debuginfod_begin();
+ debuginfod_client* c;
+ pr_debug("Downloading debug info with build id %s\n", sbuild_id);
+ c = debuginfod_begin();
if (c != NULL) {
int fd = debuginfod_find_debuginfo(c,
(const unsigned char*)sbuild_id, 0,
--
2.37.1

2022-08-12 14:17:06

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: Print debuginfod queries if -v option is used

Em Fri, Aug 12, 2022 at 01:43:53PM +0200, Martin Liška escreveu:
> When ending a perf record session, the querying of a debuginfod
> server can take quite some time. Inform a user about it when
> -v options is used.

Thanks, applied.

- Arnaldo


> Signed-off-by: Martin Liska <[email protected]>
> ---
> tools/perf/util/build-id.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 0cc68cdd84c8..d1cfce0613ee 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -653,7 +653,9 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
>
> #ifdef HAVE_DEBUGINFOD_SUPPORT
> if (realname == NULL) {
> - debuginfod_client* c = debuginfod_begin();
> + debuginfod_client* c;
> + pr_debug("Downloading debug info with build id %s\n", sbuild_id);
> + c = debuginfod_begin();
> if (c != NULL) {
> int fd = debuginfod_find_debuginfo(c,
> (const unsigned char*)sbuild_id, 0,
> --
> 2.37.1

--

- Arnaldo