Now that there is driver support for the USB device, enable it.
Signed-off-by: Michael Walle <[email protected]>
---
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
index 5a6c5f7c371a..d0d26e136c38 100644
--- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
+++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
@@ -200,6 +200,11 @@ &switch {
status = "okay";
};
+&udc {
+ atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+};
+
&watchdog {
status = "okay";
};
--
2.30.2
Hi, Michael,
On 05.07.2022 16:06, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Now that there is driver support for the USB device, enable it.
>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 5a6c5f7c371a..d0d26e136c38 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -200,6 +200,11 @@ &switch {
> status = "okay";
> };
>
> +&udc {
> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
Can you also add pinctrl to avoid issues described in:
commit 5ba6291086d2ae8006be9e0f19bf2001a85c9dc1
Author: Cristian Birsan <[email protected]>
Date: Wed Nov 18 14:00:17 2020 +0200
ARM: dts: at91: sam9x60: add pincontrol for USB Host
The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without
it the driver probes but VBus is not powered because of wrong pincontrol
configuration.
Fixes: 1e5f532c2737 ("ARM: dts: at91: sam9x60: add device tree for soc
and board")
Signed-off-by: Cristian Birsan <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Acked-by: Ludovic Desroches <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Thank you,
Claudiu Beznea
> + status = "okay";
> +};
> +
> &watchdog {
> status = "okay";
> };
> --
> 2.30.2
>
Hi Claudiu,
Am 2022-07-06 10:41, schrieb [email protected]:
> On 05.07.2022 16:06, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> Now that there is driver support for the USB device, enable it.
>>
>> Signed-off-by: Michael Walle <[email protected]>
>> ---
>> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> index 5a6c5f7c371a..d0d26e136c38 100644
>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> @@ -200,6 +200,11 @@ &switch {
>> status = "okay";
>> };
>>
>> +&udc {
>> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>
> Can you also add pinctrl to avoid issues described in:
Do I need a pinctrl node even if I just use it as a gpio?
Isn't that handled automatically by the
.gpio_request_enable op?
-michael
On 06.07.2022 11:57, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Hi Claudiu,
>
> Am 2022-07-06 10:41, schrieb [email protected]:
>> On 05.07.2022 16:06, Michael Walle wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>> the content is safe
>>>
>>> Now that there is driver support for the USB device, enable it.
>>>
>>> Signed-off-by: Michael Walle <[email protected]>
>>> ---
>>> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> index 5a6c5f7c371a..d0d26e136c38 100644
>>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> @@ -200,6 +200,11 @@ &switch {
>>> status = "okay";
>>> };
>>>
>>> +&udc {
>>> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>>
>> Can you also add pinctrl to avoid issues described in:
>
> Do I need a pinctrl node even if I just use it as a gpio?
> Isn't that handled automatically by the
> .gpio_request_enable op?
I cannot say for sure.
Looking a bit though it I think the issue described in commit I pointed may
come from the fact that struct gpio_chip::request may be
gpiochip_generic_request() which may return 0 in case
list_empty(&gc->gpiodev->pin_ranges) is true. The commit that I pointed was
introduced after commit 2ab73c6d8323 ("gpio: Support GPIO controllers
without pin-ranges") but I don't have more knowledge on it.
>
> -michael
Am 2022-07-07 11:18, schrieb [email protected]:
> On 06.07.2022 11:57, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the
>> content is safe
>>
>> Hi Claudiu,
>>
>> Am 2022-07-06 10:41, schrieb [email protected]:
>>> On 05.07.2022 16:06, Michael Walle wrote:
>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>>>> know
>>>> the content is safe
>>>>
>>>> Now that there is driver support for the USB device, enable it.
>>>>
>>>> Signed-off-by: Michael Walle <[email protected]>
>>>> ---
>>>> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> index 5a6c5f7c371a..d0d26e136c38 100644
>>>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> @@ -200,6 +200,11 @@ &switch {
>>>> status = "okay";
>>>> };
>>>>
>>>> +&udc {
>>>> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>>>
>>> Can you also add pinctrl to avoid issues described in:
>>
>> Do I need a pinctrl node even if I just use it as a gpio?
>> Isn't that handled automatically by the
>> .gpio_request_enable op?
>
> I cannot say for sure.
>
> Looking a bit though it I think the issue described in commit I pointed
> may
> come from the fact that struct gpio_chip::request may be
> gpiochip_generic_request() which may return 0 in case
> list_empty(&gc->gpiodev->pin_ranges) is true. The commit that I pointed
> was
> introduced after commit 2ab73c6d8323 ("gpio: Support GPIO controllers
> without pin-ranges") but I don't have more knowledge on it.
>
I'll just add it :) Thanks!
-michael