2023-04-21 19:13:51

by Krzysztof Kozlowski

Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

The camera's pinctrl configuration is simply empty and not effective.
Remove it to fix dtbs_check warnings like:

s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type 'array'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/s5pv210.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index d9436bbf77c8..faa3682ab5dd 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {

camera: camera@fa600000 {
compatible = "samsung,fimc";
- pinctrl-names = "default";
- pinctrl-0 = <>;
clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;
clock-names = "sclk_cam0", "sclk_cam1";
#address-cells = <1>;
--
2.34.1

2023-04-23 05:31:43

by Alim Akhtar

Subject: RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Saturday, April 22, 2023 12:32 AM
> To: Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>
> Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
> configuration
>
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
>
> s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type
> 'array'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Alim Akhtar <[email protected]>

> arch/arm/boot/dts/s5pv210.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi
> b/arch/arm/boot/dts/s5pv210.dtsi index d9436bbf77c8..faa3682ab5dd
> 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {
>
> camera: camera@fa600000 {
> compatible = "samsung,fimc";
> - pinctrl-names = "default";
> - pinctrl-0 = <>;
> clocks = <&clocks SCLK_CAM0>, <&clocks
> SCLK_CAM1>;
> clock-names = "sclk_cam0", "sclk_cam1";
> #address-cells = <1>;
> --
> 2.34.1

2023-05-08 17:08:04

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

On Fri, 21 Apr 2023 21:02:02 +0200, Krzysztof Kozlowski wrote:
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
>
> s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type 'array'
>
>

Applied, thanks!

[1/1] ARM: dts: s5pv210: remove empty camera pinctrl configuration
https://git.kernel.org/krzk/linux/c/b8039b4e40094e81351221275ed61ee7643cdb91

Best regards,
--
Krzysztof Kozlowski <[email protected]>