2023-11-15 15:23:11

by Andrew Lunn

Subject: Re: [PATCH 5/9] net: mdio: ipq4019: support MDIO clock frequency divider

> + /* MDIO default frequency is 6.25MHz */
> + priv->clk_div = 0xf;

802.3 says MDC should be 2.5Mhz. Its O.K. to support faster clocks,
but it should be an optional DT property, clock-frequency as described
in the binding.

Andrew

2023-11-16 10:48:19

by Luo Jie

Subject: Re: [PATCH 5/9] net: mdio: ipq4019: support MDIO clock frequency divider

On 11/15/2023 11:22 PM, Andrew Lunn wrote:
>> + /* MDIO default frequency is 6.25MHz */
>> + priv->clk_div = 0xf;
>
> 802.3 says MDC should be 2.5Mhz. Its O.K. to support faster clocks,
> but it should be an optional DT property, clock-frequency as described
> in the binding.
>
> Andrew

Ok, Andrew, will add the DT property "clock-frequency" to support this
clock divider in the next patch set, thanks.