2021-10-14 23:09:27

by Christophe JAILLET

Subject: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/xen/pvcalls-back.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index b47fd8435061..d6f945fd4147 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
}
sock_release(mappass->sock);
- flush_workqueue(mappass->wq);
destroy_workqueue(mappass->wq);
kfree(mappass);

--
2.30.2

2021-10-15 01:34:36

by Stefano Stabellini

Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls

On Thu, 14 Oct 2021, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Acked-by: Stefano Stabellini <[email protected]>


> ---
> drivers/xen/pvcalls-back.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index b47fd8435061..d6f945fd4147 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
> write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
> }
> sock_release(mappass->sock);
> - flush_workqueue(mappass->wq);
> destroy_workqueue(mappass->wq);
> kfree(mappass);
>
> --
> 2.30.2
>

2021-10-27 21:28:23

by Boris Ostrovsky

Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls

On 10/14/21 3:42 PM, Stefano Stabellini wrote:
> On Thu, 14 Oct 2021, Christophe JAILLET wrote:
>> 'destroy_workqueue()' already drains the queue before destroying it, so
>> there is no need to flush it explicitly.
>>
>> Remove the redundant 'flush_workqueue()' calls.
>>
>> This was generated with coccinelle:
>>
>> @@
>> expression E;
>> @@
>> - flush_workqueue(E);
>> destroy_workqueue(E);
>>
>> Signed-off-by: Christophe JAILLET <[email protected]>
> Acked-by: Stefano Stabellini <[email protected]>
>

Applied to for-linus-5.16


-boris