2024-02-15 13:58:33

by Masahiro Yamada

Subject: [PATCH] sparc: select FRAME_POINTER instead of redefining it

Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
should select it.

Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
also be selected to avoid the unmet dependency warning.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/sparc/Kconfig.debug | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
index 37e003665de6..d475a056a2e0 100644
--- a/arch/sparc/Kconfig.debug
+++ b/arch/sparc/Kconfig.debug
@@ -8,11 +8,8 @@ config MCOUNT
bool
depends on SPARC64
depends on FUNCTION_TRACER
- default y
-
-config FRAME_POINTER
- bool
- depends on MCOUNT
+ select ARCH_WANT_FRAME_POINTERS
+ select FRAME_POINTER
default y

config HAVE_HARDLOCKUP_DETECTOR_SPARC64
--
2.40.1

2024-02-15 16:48:05

by Randy Dunlap

Subject: Re: [PATCH] sparc: select FRAME_POINTER instead of redefining it

On 2/15/24 05:57, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
>
> arch/sparc/Kconfig.debug | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
> index 37e003665de6..d475a056a2e0 100644
> --- a/arch/sparc/Kconfig.debug
> +++ b/arch/sparc/Kconfig.debug
> @@ -8,11 +8,8 @@ config MCOUNT
> bool
> depends on SPARC64
> depends on FUNCTION_TRACER
> - default y
> -
> -config FRAME_POINTER
> - bool
> - depends on MCOUNT
> + select ARCH_WANT_FRAME_POINTERS
> + select FRAME_POINTER
> default y
>
> config HAVE_HARDLOCKUP_DETECTOR_SPARC64

--
#Randy

2024-02-16 16:25:50

by Andreas Larsson

Subject: Re: [PATCH] sparc: select FRAME_POINTER instead of redefining it

On 2024-02-15 14:57, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Applied to my for-next branch.

Thanks,
Andreas