2024-04-01 20:49:53

by Abhinav Kumar

Subject: [PATCH] drm: ci: fix the xfails for apq8016

After IGT migrating to dynamic sub-tests, the pipe prefixes
in the expected fails list are incorrect. Lets drop those
to accurately match the expected fails.

In addition, update the xfails list to match the current passing
list. This should have ideally failed in the CI run because some
tests were marked as fail even though they passed but due to the
mismatch in test names, the matching didn't correctly work and was
resulting in those failures not being seen.

Here is the passing pipeline for apq8016 with this change:

https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562

Signed-off-by: Abhinav Kumar <[email protected]>
---
drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
index 44a5c62dedad..b14d4e884971 100644
--- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
+++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
@@ -1,17 +1,6 @@
kms_3d,Fail
kms_addfb_basic@addfb25-bad-modifier,Fail
-kms_cursor_legacy@all-pipes-forked-bo,Fail
-kms_cursor_legacy@all-pipes-forked-move,Fail
-kms_cursor_legacy@all-pipes-single-bo,Fail
-kms_cursor_legacy@all-pipes-single-move,Fail
-kms_cursor_legacy@all-pipes-torture-bo,Fail
-kms_cursor_legacy@all-pipes-torture-move,Fail
-kms_cursor_legacy@pipe-A-forked-bo,Fail
-kms_cursor_legacy@pipe-A-forked-move,Fail
-kms_cursor_legacy@pipe-A-single-bo,Fail
-kms_cursor_legacy@pipe-A-single-move,Fail
-kms_cursor_legacy@pipe-A-torture-bo,Fail
-kms_cursor_legacy@pipe-A-torture-move,Fail
+kms_cursor_legacy@torture-bo,Fail
kms_force_connector_basic@force-edid,Fail
kms_hdmi_inject@inject-4k,Fail
kms_selftest@drm_format,Timeout
--
2.43.2

2024-04-05 16:47:16

by Dmitry Baryshkov

Subject: Re: [PATCH] drm: ci: fix the xfails for apq8016

On Mon, Apr 01, 2024 at 01:48:58PM -0700, Abhinav Kumar wrote:
> After IGT migrating to dynamic sub-tests, the pipe prefixes
> in the expected fails list are incorrect. Lets drop those
> to accurately match the expected fails.
>
> In addition, update the xfails list to match the current passing
> list. This should have ideally failed in the CI run because some
> tests were marked as fail even though they passed but due to the
> mismatch in test names, the matching didn't correctly work and was
> resulting in those failures not being seen.
>
> Here is the passing pipeline for apq8016 with this change:
>
> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>
> Signed-off-by: Abhinav Kumar <[email protected]>
> ---
> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-04-08 17:05:04

by Abhinav Kumar

Subject: Re: [PATCH] drm: ci: fix the xfails for apq8016

Hi Helen

Gentle reminder on this.

If you are okay, we can land it via msm-next tree...

Thanks

Abhinav

On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
> After IGT migrating to dynamic sub-tests, the pipe prefixes
> in the expected fails list are incorrect. Lets drop those
> to accurately match the expected fails.
>
> In addition, update the xfails list to match the current passing
> list. This should have ideally failed in the CI run because some
> tests were marked as fail even though they passed but due to the
> mismatch in test names, the matching didn't correctly work and was
> resulting in those failures not being seen.
>
> Here is the passing pipeline for apq8016 with this change:
>
> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>
> Signed-off-by: Abhinav Kumar <[email protected]>
> ---
> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> index 44a5c62dedad..b14d4e884971 100644
> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> @@ -1,17 +1,6 @@
> kms_3d,Fail
> kms_addfb_basic@addfb25-bad-modifier,Fail
> -kms_cursor_legacy@all-pipes-forked-bo,Fail
> -kms_cursor_legacy@all-pipes-forked-move,Fail
> -kms_cursor_legacy@all-pipes-single-bo,Fail
> -kms_cursor_legacy@all-pipes-single-move,Fail
> -kms_cursor_legacy@all-pipes-torture-bo,Fail
> -kms_cursor_legacy@all-pipes-torture-move,Fail
> -kms_cursor_legacy@pipe-A-forked-bo,Fail
> -kms_cursor_legacy@pipe-A-forked-move,Fail
> -kms_cursor_legacy@pipe-A-single-bo,Fail
> -kms_cursor_legacy@pipe-A-single-move,Fail
> -kms_cursor_legacy@pipe-A-torture-bo,Fail
> -kms_cursor_legacy@pipe-A-torture-move,Fail
> +kms_cursor_legacy@torture-bo,Fail
> kms_force_connector_basic@force-edid,Fail
> kms_hdmi_inject@inject-4k,Fail
> kms_selftest@drm_format,Timeout

2024-04-25 14:02:13

by Helen Koike

Subject: Re: [PATCH] drm: ci: fix the xfails for apq8016

On 08/04/2024 14:04, Abhinav Kumar wrote:
> Hi Helen
>
> Gentle reminder on this.
>
> If you are okay, we can land it via msm-next tree...
>
> Thanks
>
> Abhinav
>
> On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
>> After IGT migrating to dynamic sub-tests, the pipe prefixes
>> in the expected fails list are incorrect. Lets drop those
>> to accurately match the expected fails.
>>
>> In addition, update the xfails list to match the current passing
>> list. This should have ideally failed in the CI run because some
>> tests were marked as fail even though they passed but due to the
>> mismatch in test names, the matching didn't correctly work and was
>> resulting in those failures not being seen.
>>
>> Here is the passing pipeline for apq8016 with this change:
>>
>> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>>
>> Signed-off-by: Abhinav Kumar <[email protected]>

I'm sorry about my delay.

Acked-by: Helen Koike <[email protected]>

I'm also merging it to msm-misc-next.

Regards,
Helen

>> ---
>>   drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
>>   1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> index 44a5c62dedad..b14d4e884971 100644
>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> @@ -1,17 +1,6 @@
>>   kms_3d,Fail
>>   kms_addfb_basic@addfb25-bad-modifier,Fail
>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>> -kms_cursor_legacy@all-pipes-single-move,Fail
>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>> -kms_cursor_legacy@pipe-A-single-move,Fail
>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>> +kms_cursor_legacy@torture-bo,Fail
>>   kms_force_connector_basic@force-edid,Fail
>>   kms_hdmi_inject@inject-4k,Fail
>>   kms_selftest@drm_format,Timeout

2024-04-29 20:06:51

by Helen Koike

Subject: Re: [PATCH] drm: ci: fix the xfails for apq8016

On 25/04/2024 11:01, Helen Koike wrote:
>
>
> On 08/04/2024 14:04, Abhinav Kumar wrote:
>> Hi Helen
>>
>> Gentle reminder on this.
>>
>> If you are okay, we can land it via msm-next tree...
>>
>> Thanks
>>
>> Abhinav
>>
>> On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
>>> After IGT migrating to dynamic sub-tests, the pipe prefixes
>>> in the expected fails list are incorrect. Lets drop those
>>> to accurately match the expected fails.
>>>
>>> In addition, update the xfails list to match the current passing
>>> list. This should have ideally failed in the CI run because some
>>> tests were marked as fail even though they passed but due to the
>>> mismatch in test names, the matching didn't correctly work and was
>>> resulting in those failures not being seen.
>>>
>>> Here is the passing pipeline for apq8016 with this change:
>>>
>>> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>>>
>>> Signed-off-by: Abhinav Kumar <[email protected]>
>
> I'm sorry about my delay.
>
> Acked-by: Helen Koike <[email protected]>
>
> I'm also merging it to msm-misc-next.

Applied, thanks.

Helen

>
> Regards,
> Helen
>
>>> ---
>>>   drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
>>>   1 file changed, 1 insertion(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> index 44a5c62dedad..b14d4e884971 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> @@ -1,17 +1,6 @@
>>>   kms_3d,Fail
>>>   kms_addfb_basic@addfb25-bad-modifier,Fail
>>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>>> -kms_cursor_legacy@all-pipes-single-move,Fail
>>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>>> -kms_cursor_legacy@pipe-A-single-move,Fail
>>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>>> +kms_cursor_legacy@torture-bo,Fail
>>>   kms_force_connector_basic@force-edid,Fail
>>>   kms_hdmi_inject@inject-4k,Fail
>>>   kms_selftest@drm_format,Timeout