2016-12-16 09:13:31

by Arnd Bergmann

[permalink] [raw]

Subject: [PATCH] ARM: imx: remove unused device definitions

---

I stumbled over these during build testing, they are evidently
not referenced anywhere any more.

Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/mach-imx/devices/platform-flexcan.c | 9 ---------
arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
2 files changed, 19 deletions(-)

diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
index 55d61eaf63c6..8a1a2fc4ce10 100644
--- a/arch/arm/mach-imx/devices/platform-flexcan.c
+++ b/arch/arm/mach-imx/devices/platform-flexcan.c
@@ -19,15 +19,6 @@
#define imx_flexcan_data_entry(soc, _id, _hwid, _size) \
[_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)

-#ifdef CONFIG_SOC_IMX25
-const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
-#define imx25_flexcan_data_entry(_id, _hwid) \
- imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
- imx25_flexcan_data_entry(0, 1),
- imx25_flexcan_data_entry(1, 2),
-};
-#endif /* ifdef CONFIG_SOC_IMX25 */
-
#ifdef CONFIG_SOC_IMX35
const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
#define imx35_flexcan_data_entry(_id, _hwid) \
diff --git a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
index 3d039ef021e0..466c9ccc6675 100644
--- a/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
+++ b/arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c
@@ -22,16 +22,6 @@
#define imx_sdhci_esdhc_imx_data_entry(soc, devid, id, hwid) \
[id] = imx_sdhci_esdhc_imx_data_entry_single(soc, devid, id, hwid)

-#ifdef CONFIG_SOC_IMX25
-const struct imx_sdhci_esdhc_imx_data
-imx25_sdhci_esdhc_imx_data[] __initconst = {
-#define imx25_sdhci_esdhc_imx_data_entry(_id, _hwid) \
- imx_sdhci_esdhc_imx_data_entry(MX25, "sdhci-esdhc-imx25", _id, _hwid)
- imx25_sdhci_esdhc_imx_data_entry(0, 1),
- imx25_sdhci_esdhc_imx_data_entry(1, 2),
-};
-#endif /* ifdef CONFIG_SOC_IMX25 */
-
#ifdef CONFIG_SOC_IMX35
const struct imx_sdhci_esdhc_imx_data
imx35_sdhci_esdhc_imx_data[] __initconst = {
--
2.9.0

2016-12-16 09:11:21

by Marc Kleine-Budde

[permalink] [raw]

Subject: Re: [PATCH] ARM: imx: remove unused device definitions

---

On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
> I stumbled over these during build testing, they are evidently
> not referenced anywhere any more.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> arch/arm/mach-imx/devices/platform-flexcan.c | 9 ---------
> arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
> 2 files changed, 19 deletions(-)
>
> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
> index 55d61eaf63c6..8a1a2fc4ce10 100644
> --- a/arch/arm/mach-imx/devices/platform-flexcan.c
> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
> @@ -19,15 +19,6 @@
> #define imx_flexcan_data_entry(soc, _id, _hwid, _size) \
> [_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
>
> -#ifdef CONFIG_SOC_IMX25
> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
> -#define imx25_flexcan_data_entry(_id, _hwid) \
> - imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
> - imx25_flexcan_data_entry(0, 1),
> - imx25_flexcan_data_entry(1, 2),
> -};
> -#endif /* ifdef CONFIG_SOC_IMX25 */
> -
> #ifdef CONFIG_SOC_IMX35
> const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
> #define imx35_flexcan_data_entry(_id, _hwid) \

What about the imx35 variant?

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

---

Attachments:

signature.asc (488.00 B)
OpenPGP digital signature

2016-12-16 09:24:42

by Arnd Bergmann

[permalink] [raw]

Subject: Re: [PATCH] ARM: imx: remove unused device definitions

---

On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote:
> On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
> > I stumbled over these during build testing, they are evidently
> > not referenced anywhere any more.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > ---
> > arch/arm/mach-imx/devices/platform-flexcan.c | 9 ---------
> > arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
> > 2 files changed, 19 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
> > index 55d61eaf63c6..8a1a2fc4ce10 100644
> > --- a/arch/arm/mach-imx/devices/platform-flexcan.c
> > +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
> > @@ -19,15 +19,6 @@
> > #define imx_flexcan_data_entry(soc, _id, _hwid, _size) \
> > [_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
> >
> > -#ifdef CONFIG_SOC_IMX25
> > -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
> > -#define imx25_flexcan_data_entry(_id, _hwid) \
> > - imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
> > - imx25_flexcan_data_entry(0, 1),
> > - imx25_flexcan_data_entry(1, 2),
> > -};
> > -#endif /* ifdef CONFIG_SOC_IMX25 */
> > -
> > #ifdef CONFIG_SOC_IMX35
> > const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
> > #define imx35_flexcan_data_entry(_id, _hwid) \
>
> What about the imx35 variant?
>

It's used from here:

arch/arm/mach-imx/mach-pcm043.c: imx35_add_flexcan1();

Arnd

2016-12-16 09:29:08

by Marc Kleine-Budde

[permalink] [raw]

Subject: Re: [PATCH] ARM: imx: remove unused device definitions

---

On 12/16/2016 10:23 AM, Arnd Bergmann wrote:
> On Friday, December 16, 2016 10:10:49 AM CET Marc Kleine-Budde wrote:
>> On 12/16/2016 10:05 AM, Arnd Bergmann wrote:
>>> I stumbled over these during build testing, they are evidently
>>> not referenced anywhere any more.
>>>
>>> Signed-off-by: Arnd Bergmann <[email protected]>
>>> ---
>>> arch/arm/mach-imx/devices/platform-flexcan.c | 9 ---------
>>> arch/arm/mach-imx/devices/platform-sdhci-esdhc-imx.c | 10 ----------
>>> 2 files changed, 19 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-imx/devices/platform-flexcan.c b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> index 55d61eaf63c6..8a1a2fc4ce10 100644
>>> --- a/arch/arm/mach-imx/devices/platform-flexcan.c
>>> +++ b/arch/arm/mach-imx/devices/platform-flexcan.c
>>> @@ -19,15 +19,6 @@
>>> #define imx_flexcan_data_entry(soc, _id, _hwid, _size) \
>>> [_id] = imx_flexcan_data_entry_single(soc, _id, _hwid, _size)
>>>
>>> -#ifdef CONFIG_SOC_IMX25
>>> -const struct imx_flexcan_data imx25_flexcan_data[] __initconst = {
>>> -#define imx25_flexcan_data_entry(_id, _hwid) \
>>> - imx_flexcan_data_entry(MX25, _id, _hwid, SZ_16K)
>>> - imx25_flexcan_data_entry(0, 1),
>>> - imx25_flexcan_data_entry(1, 2),
>>> -};
>>> -#endif /* ifdef CONFIG_SOC_IMX25 */
>>> -
>>> #ifdef CONFIG_SOC_IMX35
>>> const struct imx_flexcan_data imx35_flexcan_data[] __initconst = {
>>> #define imx35_flexcan_data_entry(_id, _hwid) \
>>
>> What about the imx35 variant?
>>
>
> It's used from here:
>
> arch/arm/mach-imx/mach-pcm043.c: imx35_add_flexcan1();

Yes, you're right. Sorry, I searched before my 2nd tee.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

---

Attachments:

signature.asc (488.00 B)
OpenPGP digital signature