PCM platform driver binds to the platform device created by
ACP5x PCI device. PCM driver registers ALSA DMA components
with ASoC framework.
Signed-off-by: Vijendar Mukunda <[email protected]>
---
sound/soc/amd/vangogh/acp5x-pcm-dma.c | 79 +++++++++++++++++++++++++++
sound/soc/amd/vangogh/acp5x.h | 4 ++
2 files changed, 83 insertions(+)
create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
new file mode 100644
index 000000000000..efcf01eb89ae
--- /dev/null
+++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
@@ -0,0 +1,79 @@
+// SPDX-License-Identifier: GPL-2.0+
+//
+// AMD ALSA SoC PCM Driver
+//
+// Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+
+#include "acp5x.h"
+
+#define DRV_NAME "acp5x_i2s_dma"
+
+static const struct snd_soc_component_driver acp5x_i2s_component = {
+ .name = DRV_NAME,
+};
+
+static int acp5x_audio_probe(struct platform_device *pdev)
+{
+ struct resource *res;
+ struct i2s_dev_data *adata;
+ int status;
+
+ if (!pdev->dev.platform_data) {
+ dev_err(&pdev->dev, "platform_data not retrieved\n");
+ return -ENODEV;
+ }
+ irqflags = *((unsigned int *)(pdev->dev.platform_data));
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res) {
+ dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
+ return -ENODEV;
+ }
+
+ adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
+ if (!adata)
+ return -ENOMEM;
+
+ adata->acp5x_base = devm_ioremap(&pdev->dev, res->start,
+ resource_size(res));
+ if (!adata->acp5x_base)
+ return -ENOMEM;
+ dev_set_drvdata(&pdev->dev, adata);
+ status = devm_snd_soc_register_component(&pdev->dev,
+ &acp5x_i2s_component,
+ NULL, 0);
+ if (status) {
+ dev_err(&pdev->dev, "Fail to register acp i2s component\n");
+ return -ENODEV;
+ }
+ return 0;
+}
+
+static int acp5x_audio_remove(struct platform_device *pdev)
+{
+ return 0;
+}
+
+static struct platform_driver acp5x_dma_driver = {
+ .probe = acp5x_audio_probe,
+ .remove = acp5x_audio_remove,
+ .driver = {
+ .name = "acp5x_i2s_dma",
+ },
+};
+
+module_platform_driver(acp5x_dma_driver);
+
+MODULE_AUTHOR("[email protected]");
+MODULE_DESCRIPTION("AMD ACP 5.x PCM Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h
index 365e80b56ff9..eca642614b4f 100644
--- a/sound/soc/amd/vangogh/acp5x.h
+++ b/sound/soc/amd/vangogh/acp5x.h
@@ -32,6 +32,10 @@
#define I2S_MODE 0x00
#define ACP5x_I2S_MODE 0x00
+struct i2s_dev_data {
+ void __iomem *acp5x_base;
+};
+
static inline u32 acp_readl(void __iomem *base_addr)
{
return readl(base_addr - ACP5x_PHY_BASE_ADDRESS);
--
2.17.1
On Wed, Jul 07, 2021 at 11:26:16AM +0530, Vijendar Mukunda wrote:
> +static int acp5x_audio_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
Just drop this since it's empty.
> +static int acp5x_audio_remove(struct platform_device *pdev)
> +{
> + return 0;
> +}
can this be removed here and...
> +
> +static struct platform_driver acp5x_dma_driver = {
> + .probe = acp5x_audio_probe,
> + .remove = acp5x_audio_remove,
... here?
> + .driver = {
> + .name = "acp5x_i2s_dma",
> + },
> +};
On 7/7/21 9:54 PM, Mark Brown wrote:
> On Wed, Jul 07, 2021 at 11:26:16AM +0530, Vijendar Mukunda wrote:
>
>> +static int acp5x_audio_remove(struct platform_device *pdev)
>> +{
>> + return 0;
>> +}
>
> Just drop this since it's empty.
>
Will drop the code and post the new version.
On 7/7/21 9:47 PM, Pierre-Louis Bossart wrote:
>
>> +static int acp5x_audio_remove(struct platform_device *pdev)
>> +{
>> + return 0;
>> +}
>
> can this be removed here and...
will remove it.
>> +
>> +static struct platform_driver acp5x_dma_driver = {
>> + .probe = acp5x_audio_probe,
>> + .remove = acp5x_audio_remove,
>
> ... here?
>
will fix it and post the new version.
>> + .driver = {
>> + .name = "acp5x_i2s_dma",
>> + },
>> +};