> On Tue, 24 Oct 2017, [email protected] wrote:
> > - if (event->hw.idx >= UNCORE_PMC_IDX_FIXED)
> > + if (event->hw.idx == UNCORE_PMC_IDX_FIXED)
> > shift = 64 - uncore_fixed_ctr_bits(box);
> > else
> > shift = 64 - uncore_perf_ctr_bits(box); diff --git
> > a/arch/x86/events/intel/uncore_snb.c
> > b/arch/x86/events/intel/uncore_snb.c
> > index db1127c..9d5cd3f 100644
> > --- a/arch/x86/events/intel/uncore_snb.c
> > +++ b/arch/x86/events/intel/uncore_snb.c
> > @@ -498,6 +498,30 @@ static void snb_uncore_imc_event_del(struct
> perf_event *event, int flags)
> > snb_uncore_imc_event_stop(event, PERF_EF_UPDATE); }
> >
> > +static void snb_uncore_imc_event_read(struct perf_event *event) {
> > + struct intel_uncore_box *box = uncore_event_to_box(event);
> > + u64 prev_count, new_count, delta;
> > + int shift;
> > +
> > + if (event->hw.idx >= UNCORE_PMC_IDX_FIXED)
>
> And this needs to be >= because?
Patch 5/5 will clean up the client IMC uncore.
Before that, we still need it to make client IMC uncore work.
This patch isolates the >= case for client IMC uncore.
Thanks,
Kan
From 1582962309734866726@xxx Thu Nov 02 13:48:18 +0000 2017
X-GM-THRID: 1582166476632080836
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread