2024-03-04 10:11:05

by Andy Yan

Subject: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

From: Andy Yan <[email protected]>

The Alpha blending for 30 bit RGB/BGR are not
functioning properly for rk3568/rk3588, so remove
it from the format list.

Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
Signed-off-by: Andy Yan <[email protected]>
---

drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
index 48170694ac6b..18efb3fe1c00 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
@@ -17,9 +17,7 @@

static const uint32_t formats_cluster[] = {
DRM_FORMAT_XRGB2101010,
- DRM_FORMAT_ARGB2101010,
DRM_FORMAT_XBGR2101010,
- DRM_FORMAT_ABGR2101010,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_ARGB8888,
DRM_FORMAT_XBGR8888,
--
2.34.1

2024-03-04 10:40:24

by Sascha Hauer

Subject: Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
> From: Andy Yan <[email protected]>
>
> The Alpha blending for 30 bit RGB/BGR are not
> functioning properly for rk3568/rk3588, so remove
> it from the format list.
>
> Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
> Signed-off-by: Andy Yan <[email protected]>
> ---

Acked-by: Sascha Hauer <[email protected]>

Sascha

>
> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> index 48170694ac6b..18efb3fe1c00 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> @@ -17,9 +17,7 @@
>
> static const uint32_t formats_cluster[] = {
> DRM_FORMAT_XRGB2101010,
> - DRM_FORMAT_ARGB2101010,
> DRM_FORMAT_XBGR2101010,
> - DRM_FORMAT_ABGR2101010,
> DRM_FORMAT_XRGB8888,
> DRM_FORMAT_ARGB8888,
> DRM_FORMAT_XBGR8888,
> --
> 2.34.1
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2024-03-23 18:28:33

by Andy Yan

Subject: Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

Hi Heiko,

Could you please to take a look at this patch?

On 3/4/24 18:40, Sascha Hauer wrote:
> On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
>> From: Andy Yan <[email protected]>
>>
>> The Alpha blending for 30 bit RGB/BGR are not
>> functioning properly for rk3568/rk3588, so remove
>> it from the format list.
>>
>> Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
>> Signed-off-by: Andy Yan <[email protected]>
>> ---
>
> Acked-by: Sascha Hauer <[email protected]>
>
> Sascha
>
>>
>> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> index 48170694ac6b..18efb3fe1c00 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> @@ -17,9 +17,7 @@
>>
>> static const uint32_t formats_cluster[] = {
>> DRM_FORMAT_XRGB2101010,
>> - DRM_FORMAT_ARGB2101010,
>> DRM_FORMAT_XBGR2101010,
>> - DRM_FORMAT_ABGR2101010,
>> DRM_FORMAT_XRGB8888,
>> DRM_FORMAT_ARGB8888,
>> DRM_FORMAT_XBGR8888,
>> --
>> 2.34.1
>>
>>
>

2024-03-26 08:53:39

by Heiko Stuebner

Subject: Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

On Mon, 4 Mar 2024 18:09:52 +0800, Andy Yan wrote:
> From: Andy Yan <[email protected]>
>
> The Alpha blending for 30 bit RGB/BGR are not
> functioning properly for rk3568/rk3588, so remove
> it from the format list.
>
>
> [...]

Applied, thanks!

[1/1] drm/rockchip: vop2: Remove AR30 and AB30 format support
commit: 905f7d53a1bc105b22d9ffd03dc11b6b42ec6ba6

Best regards,
--
Heiko Stuebner <[email protected]>