sizeof(u8) is always 1.
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/acpi/utils.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 371ac12..dd8ff63 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package,
break;
case 'B':
size_required +=
- sizeof(u8 *) +
- (element->buffer.length * sizeof(u8));
+ sizeof(u8 *) + element->buffer.length;
tail_offset += sizeof(u8 *);
break;
default:
@@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package,
memcpy(tail, element->buffer.pointer,
element->buffer.length);
head += sizeof(u8 *);
- tail += element->buffer.length * sizeof(u8);
+ tail += element->buffer.length;
break;
default:
/* Should never get here */
--
1.9.3
On Sunday, November 16, 2014 10:57:00 AM Fabian Frederick wrote:
> sizeof(u8) is always 1.
>
> Signed-off-by: Fabian Frederick <[email protected]>
Queued up for 3.19-rc1, thanks!
> ---
> drivers/acpi/utils.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 371ac12..dd8ff63 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package,
> break;
> case 'B':
> size_required +=
> - sizeof(u8 *) +
> - (element->buffer.length * sizeof(u8));
> + sizeof(u8 *) + element->buffer.length;
> tail_offset += sizeof(u8 *);
> break;
> default:
> @@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package,
> memcpy(tail, element->buffer.pointer,
> element->buffer.length);
> head += sizeof(u8 *);
> - tail += element->buffer.length * sizeof(u8);
> + tail += element->buffer.length;
> break;
> default:
> /* Should never get here */
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.