2022-12-02 23:01:29

by Alex Elder

Subject: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]
Signed-off-by: Luca Weiss <[email protected]>
---
v2: This is now based on qualcomm/for-next.

drivers/clk/qcom/clk-rpmh.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 2c2ef4b6d130e..586a810c682ca 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
[RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
[RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
[RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};

static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
--
2.34.1

2022-12-03 00:23:49

by Konrad Dybcio

Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

On 2.12.2022 23:12, Alex Elder wrote:
> From: Luca Weiss <[email protected]>
>
> The IPA core clock is required for SM6350. Define it.
>
> [[email protected]: rebased with Dmitry's changes]
> Signed-off-by: Luca Weiss <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> v2: This is now based on qualcomm/for-next.
>
> drivers/clk/qcom/clk-rpmh.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 2c2ef4b6d130e..586a810c682ca 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {

2022-12-05 23:00:05

by Bjorn Andersson

Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> From: Luca Weiss <[email protected]>
>
> The IPA core clock is required for SM6350. Define it.
>
> [[email protected]: rebased with Dmitry's changes]
> Signed-off-by: Luca Weiss <[email protected]>

Thanks for rebasing this Alex. But as you're handling the patch you need
to add your S-o-b; which will make sure your [] makes sense as well.

Regards,
Bjorn

> ---
> v2: This is now based on qualcomm/for-next.
>
> drivers/clk/qcom/clk-rpmh.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 2c2ef4b6d130e..586a810c682ca 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> --
> 2.34.1
>

2022-12-06 03:35:53

by Alex Elder

Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
>> From: Luca Weiss <[email protected]>
>>
>> The IPA core clock is required for SM6350. Define it.
>>
>> [[email protected]: rebased with Dmitry's changes]
>> Signed-off-by: Luca Weiss <[email protected]>

Sorry about that, I knew I was supposed to sign
off and thought I had.

You told me separately that this was sufficient:

Signed-off-by: Alex Elder <[email protected]>

If you want me to send a new version with the
signoff just let me know. Thanks.

-Alex
>
> Thanks for rebasing this Alex. But as you're handling the patch you need
> to add your S-o-b; which will make sure your [] makes sense as well.
>
> Regards,
> Bjorn
>
>> ---
>> v2: This is now based on qualcomm/for-next.
>>
>> drivers/clk/qcom/clk-rpmh.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 2c2ef4b6d130e..586a810c682ca 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
>> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
>> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
>> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>>
>> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
>> --
>> 2.34.1
>>

2022-12-06 19:00:00

by Bjorn Andersson

Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

On Mon, Dec 05, 2022 at 09:05:30PM -0600, Alex Elder wrote:
> On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> > > From: Luca Weiss <[email protected]>
> > >
> > > The IPA core clock is required for SM6350. Define it.
> > >
> > > [[email protected]: rebased with Dmitry's changes]
> > > Signed-off-by: Luca Weiss <[email protected]>
>
> Sorry about that, I knew I was supposed to sign
> off and thought I had.
>
> You told me separately that this was sufficient:
>
> Signed-off-by: Alex Elder <[email protected]>
>
> If you want me to send a new version with the
> signoff just let me know. Thanks.
>

That works fine, thank you.
Bjorn

> -Alex
> >
> > Thanks for rebasing this Alex. But as you're handling the patch you need
> > to add your S-o-b; which will make sure your [] makes sense as well.
> >
> > Regards,
> > Bjorn
> >
> > > ---
> > > v2: This is now based on qualcomm/for-next.
> > >
> > > drivers/clk/qcom/clk-rpmh.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > > index 2c2ef4b6d130e..586a810c682ca 100644
> > > --- a/drivers/clk/qcom/clk-rpmh.c
> > > +++ b/drivers/clk/qcom/clk-rpmh.c
> > > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> > > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> > > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> > > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> > > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> > > };
> > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> > > --
> > > 2.34.1
> > >
>

2022-12-07 16:23:22

by Bjorn Andersson

Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

On Fri, 2 Dec 2022 16:12:40 -0600, Alex Elder wrote:
> From: Luca Weiss <[email protected]>
>
> The IPA core clock is required for SM6350. Define it.
>
> [[email protected]: rebased with Dmitry's changes]
>
>
> [...]

Applied, thanks!

[1/1] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
commit: 2931aa6758da9f871b4bd7ee52a4be2f9d24e6ce

Best regards,
--
Bjorn Andersson <[email protected]>