2020-09-21 11:25:37

by Pavel Machek

[permalink] [raw]
Subject: [PATCH] qla2xxx: Use constant when it is known.

Directly return constant when it is known, to make code easier to
understand.

Signed-off-by: Pavel Machek (CIP) <[email protected]>

diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 90bbc61f361b..248197e9e8ea 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -530,7 +530,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
fc_port_t *fcport;
struct srb_iocb *nvme;
struct scsi_qla_host *vha;
- int rval = -ENODEV;
+ int rval;
srb_t *sp;
struct qla_qpair *qpair = hw_queue_handle;
struct nvme_private *priv = fd->private;
@@ -538,14 +538,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,

if (!priv) {
/* nvme association has been torn down */
- return rval;
+ return -ENODEV;
}

fcport = qla_rport->fcport;

if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
(fcport && fcport->deleted))
- return rval;
+ return -ENODEV;

vha = fcport->vha;
/*

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:
(No filename) (1.14 kB)
 signature.asc (201.00 B)
 Download all attachments

2020-10-07 13:31:22

by Himanshu Madhani

[permalink] [raw]
Subject: Re: [PATCH] qla2xxx: Use constant when it is known.



> On Sep 21, 2020, at 6:23 AM, Pavel Machek <[email protected]> wrote:
>
> Directly return constant when it is known, to make code easier to
> understand.
>
> Signed-off-by: Pavel Machek (CIP) <[email protected]>
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 90bbc61f361b..248197e9e8ea 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -530,7 +530,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
> fc_port_t *fcport;
> struct srb_iocb *nvme;
> struct scsi_qla_host *vha;
> - int rval = -ENODEV;
> + int rval;
> srb_t *sp;
> struct qla_qpair *qpair = hw_queue_handle;
> struct nvme_private *priv = fd->private;
> @@ -538,14 +538,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
>
> if (!priv) {
> /* nvme association has been torn down */
> - return rval;
> + return -ENODEV;
> }
>
> fcport = qla_rport->fcport;
>
> if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
> (fcport && fcport->deleted))
> - return rval;
> + return -ENODEV;
>
> vha = fcport->vha;
> /*
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2020-10-08 02:16:20

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] qla2xxx: Use constant when it is known.


Pavel,

> Directly return constant when it is known, to make code easier to
> understand.

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-10-14 07:06:30

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] qla2xxx: Use constant when it is known.

On Mon, 21 Sep 2020 13:23:40 +0200, Pavel Machek wrote:

> Directly return constant when it is known, to make code easier to
> understand.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Use constant when it is known
https://git.kernel.org/mkp/scsi/c/b994718760fa

--
Martin K. Petersen Oracle Linux Engineering