2024-05-08 21:46:08

by Mario Limonciello

Subject: [PATCH v2] drm/amd/display: Enable colorspace property for MST connectors

MST colorspace property support was disabled due to a series of warnings
that came up when the device was plugged in since the properties weren't
made at device creation. Create the properties in advance instead.

Suggested-by: Ville Syrjälä <[email protected]>
Fixes: 69a959610229 ("drm/amd/display: Temporary Disable MST DP Colorspace Property").
Reported-and-tested-by: Tyler Schneider <[email protected]>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3353
Signed-off-by: Mario Limonciello <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 941e96f100f4..12b036d511d0 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -613,6 +613,9 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
&connector->base,
dev->mode_config.tile_property,
0);
+ connector->colorspace_property = master->base.colorspace_property;
+ if (connector->colorspace_property)
+ drm_connector_attach_colorspace_property(connector);

drm_connector_set_path_property(connector, pathprop);

--
2.43.0

2024-05-23 14:12:34

by Harry Wentland

Subject: Re: [PATCH v2] drm/amd/display: Enable colorspace property for MST connectors

On 2024-05-08 17:45, Mario Limonciello wrote:
> MST colorspace property support was disabled due to a series of warnings
> that came up when the device was plugged in since the properties weren't
> made at device creation. Create the properties in advance instead.
>
> Suggested-by: Ville Syrjälä <[email protected]>
> Fixes: 69a959610229 ("drm/amd/display: Temporary Disable MST DP Colorspace Property").
> Reported-and-tested-by: Tyler Schneider <[email protected]>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3353
> Signed-off-by: Mario Limonciello <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 941e96f100f4..12b036d511d0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -613,6 +613,9 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
> &connector->base,
> dev->mode_config.tile_property,
> 0);
> + connector->colorspace_property = master->base.colorspace_property;
> + if (connector->colorspace_property)
> + drm_connector_attach_colorspace_property(connector);
>
> drm_connector_set_path_property(connector, pathprop);
>