2022-07-05 18:47:17

by Andy Shevchenko

Subject: [PATCH v1 1/1] Input: goodix - switch use of acpi_gpio_get_*_resource() APIs

No need to open code functionality that is provided by the
acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource().

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/input/touchscreen/goodix.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 3ad9870db108..cc52f0d21dbb 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data)
struct device *dev = &ts->client->dev;
struct acpi_resource_gpio *gpio;

- switch (ares->type) {
- case ACPI_RESOURCE_TYPE_GPIO:
- gpio = &ares->data.gpio;
- if (gpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT) {
- if (ts->gpio_int_idx == -1) {
- ts->gpio_int_idx = ts->gpio_count;
- } else {
- dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
- ts->gpio_int_idx = -2;
- }
+ if (acpi_gpio_get_irq_resource(ares, &gpio)) {
+ if (ts->gpio_int_idx == -1) {
+ ts->gpio_int_idx = ts->gpio_count;
+ } else {
+ dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
+ ts->gpio_int_idx = -2;
}
ts->gpio_count++;
- break;
- default:
- break;
- }
+ } else if (acpi_gpio_get_io_resource(ares, &gpio))
+ ts->gpio_count++;

return 0;
}
--
2.35.1

2022-07-06 21:24:59

by Hans de Goede

Subject: Re: [PATCH v1 1/1] Input: goodix - switch use of acpi_gpio_get_*_resource() APIs

Hi,

On 7/5/22 20:02, Andy Shevchenko wrote:
> No need to open code functionality that is provided by the
> acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource().
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
> drivers/input/touchscreen/goodix.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 3ad9870db108..cc52f0d21dbb 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data)
> struct device *dev = &ts->client->dev;
> struct acpi_resource_gpio *gpio;
>
> - switch (ares->type) {
> - case ACPI_RESOURCE_TYPE_GPIO:
> - gpio = &ares->data.gpio;
> - if (gpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT) {
> - if (ts->gpio_int_idx == -1) {
> - ts->gpio_int_idx = ts->gpio_count;
> - } else {
> - dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
> - ts->gpio_int_idx = -2;
> - }
> + if (acpi_gpio_get_irq_resource(ares, &gpio)) {
> + if (ts->gpio_int_idx == -1) {
> + ts->gpio_int_idx = ts->gpio_count;
> + } else {
> + dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
> + ts->gpio_int_idx = -2;
> }
> ts->gpio_count++;
> - break;
> - default:
> - break;
> - }
> + } else if (acpi_gpio_get_io_resource(ares, &gpio))
> + ts->gpio_count++;
>
> return 0;
> }

2022-07-07 00:16:48

by Dmitry Torokhov

Subject: Re: [PATCH v1 1/1] Input: goodix - switch use of acpi_gpio_get_*_resource() APIs

On Tue, Jul 05, 2022 at 09:02:51PM +0300, Andy Shevchenko wrote:
> No need to open code functionality that is provided by the
> acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource().
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Applied, thank you.

--
Dmitry