2001-12-05 17:16:17

by David Weinehall

Subject: [Todo] Remove usage of (f)suser in kernel

After a quick round of grep:ing, I came up with the following files
needing fixes to substitute usage of (f)suser for proper capabilities:

linux/include/linux/sched.h -- definitions of suser/fsuser
linux/include/linux/compatmac.h -- compability-macro for suser

linux/fs/ufs/balloc.c -- 1 occurence of fsuser

linux/drivers/net/wan/lmc/lmc_main.c -- 6 occurences of suser
linux/drivers/net/pcmcia/xircom_tulip_cb.c -- 1 occurence of suser
linux/drivers/net/fealnx.c -- 1 occurence of suser

linux/drivers/block/cciss.c -- 2 occurences of suser
linux/drivers/block/cpqarray.c -- 3 occurences of suser
linux/drivers/block/swim3.c -- 1 occurence of suser
linux/drivers/block/swim_iop.c -- 1 occurence of suser

linux/drivers/char/tty_io.c -- 4 occurences of suser
linux/drivers/char/vt.c -- 3 occurences of suser
linux/drivers/char/rocket.c -- 1 occurence of suser
linux/drivers/char/mxser.c -- 1 occurence of suser
linux/drivers/char/serial167.c -- 1 occurence of suser
linux/drivers/char/ip2main.c -- 1 occurence of suser
linux/drivers/char/rio/rio_linux.c -- 1 occurence of suser
linux/drivers/char/moxa.c -- 1 occurence of suser

linux/drivers/scsi/cpqfcTSinit.c -- 1 occurence of suser

linux/drivers/pcmcia/ds.c -- 1 occurence of suser

linux/drivers/s390/char/tubtty.c -- 1 occurence of suser

linux/drivers/media/video/zr36120.c -- 1 occurence of suser

linux/arch/i386/kernel/mtrr.c -- 9 occurences of suser

linux/arch/sparc64/kernel/ioctl32.c -- 1 occurence of suser

Since I don't know what the maintainers of some of these files want
as capabilities, I've decided not to fix this myself. zr36120.c is
only a matter of removing an #ifdef/#else/#endif combo and doing some
reindenting, though.


/David Weinehall
_ _
// David Weinehall <[email protected]> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </

2001-12-05 18:14:36

by Jeff Garzik

Subject: Re: [Todo] Remove usage of (f)suser in kernel

David Weinehall wrote:
> After a quick round of grep:ing, I came up with the following files
> needing fixes to substitute usage of (f)suser for proper capabilities:
[...]
> Since I don't know what the maintainers of some of these files want
> as capabilities, I've decided not to fix this myself. zr36120.c is
> only a matter of removing an #ifdef/#else/#endif combo and doing some
> reindenting, though.

We need to kill those in 2.5 I think. s/suser/capable(...)/ has been on
the kernel janitor's list for a while.

Jeff


--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno

2001-12-05 18:35:56

by David Weinehall

Subject: Re: [Todo] Remove usage of (f)suser in kernel

On Wed, Dec 05, 2001 at 01:14:16PM -0500, Jeff Garzik wrote:
> David Weinehall wrote:
> > After a quick round of grep:ing, I came up with the following files
> > needing fixes to substitute usage of (f)suser for proper capabilities:
> [...]
> > Since I don't know what the maintainers of some of these files want
> > as capabilities, I've decided not to fix this myself. zr36120.c is
> > only a matter of removing an #ifdef/#else/#endif combo and doing some
> > reindenting, though.
>
> We need to kill those in 2.5 I think. s/suser/capable(...)/ has been on
> the kernel janitor's list for a while.

That was kind of my intention behind this, yes.


/David
_ _
// David Weinehall <[email protected]> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </