Andrew,
here are two nbd patches to apply to 2.5.74-mm2 after two of the
previous patches (from Lou Langholtz) are reverted:
nbd-ioctl-compat.patch (patch 6)
nbd-locking-fixes.patch (patch 7)
I'm fine with leaving the first 5 patches of his in there.
The two attached patches are:
1) nbd-remove_open_release.diff - remove the unneeded nbd_open and
nbd_release functions
2) nbd-block_layer_compat.diff - ensure that nbd and the block layer
agree about device block sizes and total device sizes
and should be applied in this order.
Thanks,
Paul
Paul Clements wrote:
> The two attached patches are:
>
> 1) nbd-remove_open_release.diff - remove the unneeded nbd_open and
> nbd_release functions
Please remove the unneeded ->refcnt member as well.
> 2) nbd-block_layer_compat.diff - ensure that nbd and the block layer
> agree about device block sizes and total device sizes
Use set_blocksize, please.
Also, please split up your patches further. The Linux (Linus?) standard
is one patch per email... Also, attachments are discouraged, though not
a "no no" because of various broken corporate email systems...
Jeff
On Sun, 6 Jul 2003, Jeff Garzik wrote:
> Paul Clements wrote:
> > The two attached patches are:
> >
> > 1) nbd-remove_open_release.diff - remove the unneeded nbd_open and
> > nbd_release functions
>
> Please remove the unneeded ->refcnt member as well.
Yep, I forgot to do that...new patch on the way...
> > 2) nbd-block_layer_compat.diff - ensure that nbd and the block layer
> > agree about device block sizes and total device sizes
>
> Use set_blocksize, please.
OK, I've done that in this next patch, also on the way...
> Also, please split up your patches further. The Linux (Linus?) standard
> is one patch per email... Also, attachments are discouraged, though not
> a "no no" because of various broken corporate email systems...
OK, thanks...
--
Paul