2023-03-31 09:55:13

by Thomas Weißschuh

Subject: Re: [PATCH] Add "X570S AORUS ELITE" to known working boards

Hi,

thanks for the patch!


Mar 31, 2023 04:01:37 Brandon Nielsen <[email protected]>:

> ---
> drivers/platform/x86/gigabyte-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index 4dd39ab6ecfa..ca5124e31d2c 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
> +   DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
>     { }
> };
> -- > 2.39.2


This patch is missing a proper subject line, a commit message and Signed-off-by.
Please send a v2 and take a look how similar patches are structured.

https://lore.kernel.org/lkml/[email protected]/

Thomas

2023-03-31 17:38:21

by Hans de Goede

Subject: Re: [PATCH] Add "X570S AORUS ELITE" to known working boards

Hi,

On 3/31/23 11:44, [email protected] wrote:
> Hi,
>
> thanks for the patch!
>
>
> Mar 31, 2023 04:01:37 Brandon Nielsen <[email protected]>:
>
>> ---
>> drivers/platform/x86/gigabyte-wmi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
>> index 4dd39ab6ecfa..ca5124e31d2c 100644
>> --- a/drivers/platform/x86/gigabyte-wmi.c
>> +++ b/drivers/platform/x86/gigabyte-wmi.c
>> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
>> +   DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
>>     { }
>> };
>> -- > 2.39.2
>
>
> This patch is missing a proper subject line, a commit message and Signed-off-by.
> Please send a v2 and take a look how similar patches are structured.
>
> https://lore.kernel.org/lkml/[email protected]/

Since I'm preparing a fixes pull-req to send to Linus today
and since this is just a simple hw-id addition I have merged this now,
so that it can be included in the fixes pull-req.

I have fixed the subject and solved the missing Signed-off-by problem
by setting myself as author and crediting Brandon with a:

Reported-by: Brandon Nielsen <[email protected]>

Regards,

Hans