2023-01-18 07:23:17

by Danilo Krummrich

Subject: [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()

Don't call drm_gem_object_get() unconditionally.

Signed-off-by: Danilo Krummrich <[email protected]>
---
drivers/gpu/drm/drm_exec.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
index ed2106c22786..5713a589a6a3 100644
--- a/drivers/gpu/drm/drm_exec.c
+++ b/drivers/gpu/drm/drm_exec.c
@@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj,
goto error_unlock;
}

- drm_gem_object_get(obj);
return 0;

error_unlock:
--
2.39.0

2023-01-18 09:52:57

by Christian König

Subject: Re: [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()

That one should probably be squashed into the original patch.

Christian.

Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
> Don't call drm_gem_object_get() unconditionally.
>
> Signed-off-by: Danilo Krummrich <[email protected]>
> ---
> drivers/gpu/drm/drm_exec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
> index ed2106c22786..5713a589a6a3 100644
> --- a/drivers/gpu/drm/drm_exec.c
> +++ b/drivers/gpu/drm/drm_exec.c
> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj,
> goto error_unlock;
> }
>
> - drm_gem_object_get(obj);
> return 0;
>
> error_unlock:

2023-01-18 19:31:52

by Danilo Krummrich

Subject: Re: [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj()

On 1/18/23 09:51, Christian König wrote:
> That one should probably be squashed into the original patch.

Yes, just wanted to make it obvious for you to pick it up in case you
did not fix it already yourself.

>
> Christian.
>
> Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
>> Don't call drm_gem_object_get() unconditionally.
>>
>> Signed-off-by: Danilo Krummrich <[email protected]>
>> ---
>>   drivers/gpu/drm/drm_exec.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
>> index ed2106c22786..5713a589a6a3 100644
>> --- a/drivers/gpu/drm/drm_exec.c
>> +++ b/drivers/gpu/drm/drm_exec.c
>> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec,
>> struct drm_gem_object *obj,
>>               goto error_unlock;
>>       }
>> -    drm_gem_object_get(obj);
>>       return 0;
>>   error_unlock:
>