2021-03-18 20:30:42

by Bhaskar Chowdhury

Subject: [PATCH V2] drm/amdgpu: Fix a typo

s/traing/training/

...Plus the entire sentence construction for better readability.

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
Changes from V1:
Alex and Randy's suggestions incorporated.

drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index c325d6f53a71..bf3857867f51 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)

if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
/*
- * Long traing will encroach certain mount of bottom VRAM,
- * saving the content of this bottom VRAM to system memory
- * before training, and restoring it after training to avoid
- * VRAM corruption.
+ * Long training will encroach a certain amount on the bottom of VRAM;
+ * save the content from the bottom VRAM to system memory
+ * before training, and restore it after training to avoid
+ * VRAM corruption.
*/
sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;

--
2.26.2

2021-03-20 02:29:31

by Randy Dunlap

Subject: Re: [PATCH V2] drm/amdgpu: Fix a typo

On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:

> s/traing/training/
>
> ...Plus the entire sentence construction for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> Changes from V1:
> Alex and Randy's suggestions incorporated.
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..bf3857867f51 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> /*
> - * Long traing will encroach certain mount of bottom VRAM,
> - * saving the content of this bottom VRAM to system memory
> - * before training, and restoring it after training to avoid
> - * VRAM corruption.
> + * Long training will encroach a certain amount on the bottom of VRAM;
> + * save the content from the bottom VRAM to system memory
> + * before training, and restore it after training to avoid
> + * VRAM corruption.

These 3 new lines are indented with spaces instead of tabs. Oops. :(

(I may be too late with this comment -- sorry about that.)

> */
> sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
>
> --
> 2.26.2
>
>

2021-03-22 14:01:16

by Alex Deucher

Subject: Re: [PATCH V2] drm/amdgpu: Fix a typo

On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
<[email protected]> wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <[email protected]>
> > ---
> > Changes from V1:
> > Alex and Randy's suggestions incorporated.
> >
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..bf3857867f51 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > - * saving the content of this bottom VRAM to system memory
> > - * before training, and restoring it after training to avoid
> > - * VRAM corruption.
> > + * Long training will encroach a certain amount on the bottom of VRAM;
> > + * save the content from the bottom VRAM to system memory
> > + * before training, and restore it after training to avoid
> > + * VRAM corruption.
>
> These 3 new lines are indented with spaces instead of tabs. Oops. :(
>
> (I may be too late with this comment -- sorry about that.)

I fixed that up when I applied it.

Thanks,

Alex


>
> > */
> > sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
> >
> > --
> > 2.26.2
> >
> >
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel