2021-12-02 06:18:08

by He Ying

Subject: [PATCH] arm: Show real address of stack limit in __die()

Printing real address of stack limit makes debug easier.
And system is dying, there is no security risk to show real
address.

Signed-off-by: He Ying <[email protected]>
---
arch/arm/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index 195dff58bafc..7d7c86d00482 100644
--- a/arch/arm/kernel/traps.c
+++ b/arch/arm/kernel/traps.c
@@ -273,7 +273,7 @@ static int __die(const char *str, int err, struct pt_regs *regs)
print_modules();
__show_regs(regs);
__show_regs_alloc_free(regs);
- pr_emerg("Process %.*s (pid: %d, stack limit = 0x%p)\n",
+ pr_emerg("Process %.*s (pid: %d, stack limit = 0x%px)\n",
TASK_COMM_LEN, tsk->comm, task_pid_nr(tsk), end_of_stack(tsk));

if (!user_mode(regs) || in_interrupt()) {
--
2.17.1

2021-12-27 02:03:15

by He Ying

Subject: Re: [PATCH] arm: Show real address of stack limit in __die()

Ping. Any ideas about this patch?

?? 2021/12/2 14:19, He Ying д??:
> Printing real address of stack limit makes debug easier.
> And system is dying, there is no security risk to show real
> address.
>
> Signed-off-by: He Ying <[email protected]>
> ---
> arch/arm/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 195dff58bafc..7d7c86d00482 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -273,7 +273,7 @@ static int __die(const char *str, int err, struct pt_regs *regs)
> print_modules();
> __show_regs(regs);
> __show_regs_alloc_free(regs);
> - pr_emerg("Process %.*s (pid: %d, stack limit = 0x%p)\n",
> + pr_emerg("Process %.*s (pid: %d, stack limit = 0x%px)\n",
> TASK_COMM_LEN, tsk->comm, task_pid_nr(tsk), end_of_stack(tsk));
>
> if (!user_mode(regs) || in_interrupt()) {