2023-05-17 18:39:16

by Hamza Mahfooz

Subject: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()

set_abm_event() is never actually used. So, drop it.

Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
Reported-by: kernel test robot <[email protected]>
Reported-by: Tom Rix <[email protected]>
Signed-off-by: Hamza Mahfooz <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
2 files changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
index a66f83a61402..2fb9572ce25d 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
@@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
return ret;
}

-static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst)
-{
- bool ret = false;
- unsigned int feature_support;
-
- feature_support = abm_feature_support(abm, panel_inst);
-
- return ret;
-}
-
static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
unsigned int backlight_pwm_u16_16,
unsigned int frame_ramp,
@@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
.init_abm_config = dmub_abm_init_config_ex,
.set_abm_pause = dmub_abm_set_pause_ex,
.set_pipe_ex = dmub_abm_set_pipe_ex,
- .set_abm_event = dmub_abm_set_event_ex,
.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
};

diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
index db5cf9acafe6..d2190a3320f6 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
@@ -59,8 +59,6 @@ struct abm_funcs {
unsigned int otg_inst,
unsigned int option,
unsigned int panel_inst);
- bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst);
};

#endif
--
2.40.1

2023-05-18 00:14:43

by Rodrigo Siqueira Jordao

Subject: Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()

On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
>
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Tom Rix <[email protected]>
> Signed-off-by: Hamza Mahfooz <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
> drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
> return ret;
> }
>
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst)
> -{
> - bool ret = false;
> - unsigned int feature_support;
> -
> - feature_support = abm_feature_support(abm, panel_inst);
> -
> - return ret;
> -}
> -
> static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
> unsigned int backlight_pwm_u16_16,
> unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
> .init_abm_config = dmub_abm_init_config_ex,
> .set_abm_pause = dmub_abm_set_pause_ex,
> .set_pipe_ex = dmub_abm_set_pipe_ex,
> - .set_abm_event = dmub_abm_set_event_ex,
> .set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
> };
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
> unsigned int otg_inst,
> unsigned int option,
> unsigned int panel_inst);
> - bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst);
> };
>
> #endif

Reviewed-by: Rodrigo Siqueira <[email protected]>