2022-09-30 10:02:03

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] slimbus: stream: handle unsupported bitrates for presence rate

On 30/09/2022 11:20, Krzysztof Kozlowski wrote:
> Handle errors of getting presence rate for unsupported stream bitrate,
> instead of sending -EINVAL in change content message.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/slimbus/stream.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
> index f8eade1e0132..28fbecb3907d 100644
> --- a/drivers/slimbus/stream.c
> +++ b/drivers/slimbus/stream.c
> @@ -204,7 +204,7 @@ int slim_stream_prepare(struct slim_stream_runtime *rt,
> {
> struct slim_controller *ctrl = rt->dev->ctrl;
> struct slim_port *port;
> - int num_ports, i, port_id;
> + int num_ports, i, port_id, prrate;
>
> pr_err("%s:%d AAAA\n", __func__, __LINE__);

The context is from development tree. I'll rebase and send a v2.


Best regards,
Krzysztof

2022-09-30 10:04:12

by Konrad Dybcio

Subject: Re: [PATCH 1/2] slimbus: stream: handle unsupported bitrates for presence rate

On 30.09.2022 11:42, Krzysztof Kozlowski wrote:
> On 30/09/2022 11:20, Krzysztof Kozlowski wrote:
>> Handle errors of getting presence rate for unsupported stream bitrate,
>> instead of sending -EINVAL in change content message.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> drivers/slimbus/stream.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
>> index f8eade1e0132..28fbecb3907d 100644
>> --- a/drivers/slimbus/stream.c
>> +++ b/drivers/slimbus/stream.c
>> @@ -204,7 +204,7 @@ int slim_stream_prepare(struct slim_stream_runtime *rt,
>> {
>> struct slim_controller *ctrl = rt->dev->ctrl;
>> struct slim_port *port;
>> - int num_ports, i, port_id;
>> + int num_ports, i, port_id, prrate;
>>
>> pr_err("%s:%d AAAA\n", __func__, __LINE__);
>
> The context is from development tree. I'll rebase and send a v2.
I somehow didn't think it's out of the ordinary heh, my r-b still stands
for the changes.

Konrad
>
>
> Best regards,
> Krzysztof
>