2019-08-11 17:37:17

by Steve Longerbeam

Subject: [PATCH] media: docs-rst: Clarify duration of LP-11 mode

Add a sentence that makes it more clear when the CSI-2 transmitter
must, if possible, exit LP-11 mode. That is, maintain LP-11 mode
until stream on, at which point the transmitter activates the clock
lane and transition to HS mode.

Signed-off-by: Steve Longerbeam <[email protected]>
---
Documentation/media/kapi/csi2.rst | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/media/kapi/csi2.rst b/Documentation/media/kapi/csi2.rst
index a7e75e2eba85..6cd1d4b0df17 100644
--- a/Documentation/media/kapi/csi2.rst
+++ b/Documentation/media/kapi/csi2.rst
@@ -49,9 +49,13 @@ where

The transmitter drivers must, if possible, configure the CSI-2
transmitter to *LP-11 mode* whenever the transmitter is powered on but
-not active. Some transmitters do this automatically but some have to
-be explicitly programmed to do so, and some are unable to do so
-altogether due to hardware constraints.
+not active, and maintain *LP-11 mode* until stream on. Only until
+stream on should the transmitter activate the clock on the clock lane
+and transition to *HS mode*.
+
+Some transmitters do this automatically but some have to be explicitly
+programmed to do so, and some are unable to do so altogether due to
+hardware constraints.

Stopping the transmitter
^^^^^^^^^^^^^^^^^^^^^^^^
--
2.17.1

2019-08-12 08:54:33

by Ian Arkver

Subject: Re: [PATCH] media: docs-rst: Clarify duration of LP-11 mode

Hi Steve,

On 11/08/2019 18:36, Steve Longerbeam wrote:
> Add a sentence that makes it more clear when the CSI-2 transmitter
> must, if possible, exit LP-11 mode. That is, maintain LP-11 mode
> until stream on, at which point the transmitter activates the clock
> lane and transition to HS mode.
>
> Signed-off-by: Steve Longerbeam <[email protected]>
> ---
> Documentation/media/kapi/csi2.rst | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/media/kapi/csi2.rst b/Documentation/media/kapi/csi2.rst
> index a7e75e2eba85..6cd1d4b0df17 100644
> --- a/Documentation/media/kapi/csi2.rst
> +++ b/Documentation/media/kapi/csi2.rst
> @@ -49,9 +49,13 @@ where
>
> The transmitter drivers must, if possible, configure the CSI-2
> transmitter to *LP-11 mode* whenever the transmitter is powered on but
> -not active. Some transmitters do this automatically but some have to
> -be explicitly programmed to do so, and some are unable to do so
> -altogether due to hardware constraints.
> +not active, and maintain *LP-11 mode* until stream on. Only until

s/until/at/ perhaps?

Regards,
Ian
> +stream on should the transmitter activate the clock on the clock lane
> +and transition to *HS mode*.
> +
> +Some transmitters do this automatically but some have to be explicitly
> +programmed to do so, and some are unable to do so altogether due to
> +hardware constraints.
>
> Stopping the transmitter
> ^^^^^^^^^^^^^^^^^^^^^^^^
>

2019-08-12 21:46:36

by Steve Longerbeam

Subject: Re: [PATCH] media: docs-rst: Clarify duration of LP-11 mode

Hi Ian,

On 8/12/19 1:53 AM, Ian Arkver wrote:
> Hi Steve,
>
> On 11/08/2019 18:36, Steve Longerbeam wrote:
>> Add a sentence that makes it more clear when the CSI-2 transmitter
>> must, if possible, exit LP-11 mode. That is, maintain LP-11 mode
>> until stream on, at which point the transmitter activates the clock
>> lane and transition to HS mode.
>>
>> Signed-off-by: Steve Longerbeam <[email protected]>
>> ---
>>   Documentation/media/kapi/csi2.rst | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/media/kapi/csi2.rst
>> b/Documentation/media/kapi/csi2.rst
>> index a7e75e2eba85..6cd1d4b0df17 100644
>> --- a/Documentation/media/kapi/csi2.rst
>> +++ b/Documentation/media/kapi/csi2.rst
>> @@ -49,9 +49,13 @@ where
>>     The transmitter drivers must, if possible, configure the CSI-2
>>   transmitter to *LP-11 mode* whenever the transmitter is powered on but
>> -not active. Some transmitters do this automatically but some have to
>> -be explicitly programmed to do so, and some are unable to do so
>> -altogether due to hardware constraints.
>> +not active, and maintain *LP-11 mode* until stream on. Only until
>
> s/until/at/ perhaps?

Sure, that's a bit better language.

Steve

>
> Regards,
> Ian
>> +stream on should the transmitter activate the clock on the clock lane
>> +and transition to *HS mode*.
>> +
>> +Some transmitters do this automatically but some have to be explicitly
>> +programmed to do so, and some are unable to do so altogether due to
>> +hardware constraints.
>>     Stopping the transmitter
>>   ^^^^^^^^^^^^^^^^^^^^^^^^
>>