2016-10-05 02:36:33

by Michael Ellerman

[permalink] [raw]
Subject: Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

On Fri, 2016-29-07 at 03:55:34 UTC, Andrew Donnellan wrote:
> Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use
> for_each_child_of_node() rather than a hand-coded for loop.
>
> Remove the useless of_node_put(afu_np) call after the loop, where it's
> guaranteed that afu_np == NULL.
>
> Reported-by: SF Markus Elfring <[email protected]>
> Reported-by: Julia Lawall <[email protected]>
> Signed-off-by: Andrew Donnellan <[email protected]>
> Reviewed-by: Frederic Barrat <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/735840b44bcc998e2574faf63d1aaa

cheers