2021-04-02 09:09:50

by Luo Jiaxing

Subject: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

There are few error about open brace is reported by checkpatch.pl:

ERROR: that open brace { should be on the previous line
+static struct error_fw flash_error_table[] =
+{

So fix them all.

Signed-off-by: Jianqin Xie <[email protected]>
Signed-off-by: Luo Jiaxing <[email protected]>
---
drivers/scsi/pm8001/pm8001_ctl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index ffb4387..8802fe4 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -647,8 +647,7 @@ struct flash_command {
int code;
};

-static struct flash_command flash_command_table[] =
-{
+static struct flash_command flash_command_table[] = {
{"set_nvmd", FLASH_CMD_SET_NVMD},
{"update", FLASH_CMD_UPDATE},
{"", FLASH_CMD_NONE} /* Last entry should be NULL. */
@@ -659,8 +658,7 @@ struct error_fw {
int err_code;
};

-static struct error_fw flash_error_table[] =
-{
+static struct error_fw flash_error_table[] = {
{"Failed to open fw image file", FAIL_OPEN_BIOS_FILE},
{"image header mismatch", FLASH_UPDATE_HDR_ERR},
{"image offset mismatch", FLASH_UPDATE_OFFSET_ERR},
--
2.7.4

2021-04-02 16:04:18

by Bart Van Assche

Subject: Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

On 4/2/21 2:08 AM, Luo Jiaxing wrote:
> -static struct flash_command flash_command_table[] =
> -{
> +static struct flash_command flash_command_table[] = {
> {"set_nvmd", FLASH_CMD_SET_NVMD},
> {"update", FLASH_CMD_UPDATE},
> {"", FLASH_CMD_NONE} /* Last entry should be NULL. */

Can 'flash_command_table' be declared const?

> -static struct error_fw flash_error_table[] =
> -{
> +static struct error_fw flash_error_table[] = {
> {"Failed to open fw image file", FAIL_OPEN_BIOS_FILE},
> {"image header mismatch", FLASH_UPDATE_HDR_ERR},
> {"image offset mismatch", FLASH_UPDATE_OFFSET_ERR},

Can 'flash_error_table' be declared const?

Thanks,

Bart.

2021-04-06 16:05:29

by Luo Jiaxing

Subject: Re: [PATCH v1 2/2] scsi: pm8001: clean up for open brace

On 2021/4/3 0:03, Bart Van Assche wrote:
> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>> -static struct flash_command flash_command_table[] =
>> -{
>> +static struct flash_command flash_command_table[] = {
>> {"set_nvmd", FLASH_CMD_SET_NVMD},
>> {"update", FLASH_CMD_UPDATE},
>> {"", FLASH_CMD_NONE} /* Last entry should be NULL. */
> Can 'flash_command_table' be declared const?


Sure


>
>> -static struct error_fw flash_error_table[] =
>> -{
>> +static struct error_fw flash_error_table[] = {
>> {"Failed to open fw image file", FAIL_OPEN_BIOS_FILE},
>> {"image header mismatch", FLASH_UPDATE_HDR_ERR},
>> {"image offset mismatch", FLASH_UPDATE_OFFSET_ERR},
> Can 'flash_error_table' be declared const?


Sure


Thanks

Jiaxing


>
> Thanks,
>
> Bart.
>
> .
>