2004-06-03 20:01:55

by Flavio Stanchina

[permalink] [raw]
Subject: Re: Linux 2.6.7-rc2

Peter Osterlund wrote:
> [patch to linux/fs/nfs/read.c]
> + memset(rdata, 0, sizeof(*rdata));
> + rdata->flags = (IS_SWAPFILE(inode)? NFS_RPC_SWAPFLAGS : 0);

Wouldn't this be better as:
if (IS_SWAPFILE(inode))
rdata->flags = NFS_RPC_SWAPFLAGS;

> + rdata->args.pgbase = 0UL;

Wouldn't this be redundant?

--
Ciao, Flavio