Visually it's much easier to read/compare messages such as these
Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
if the numbers line up like this
Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
/Very/ minor, trivial thing, yes, but those messages have been annoying my
eyes for a while now so I desided to make them line up - so, here's the
patch that does that (not sure if a signed-off-by line is needed even for
trivial stuff like this, but I assume it should go with everything, so...)
Patch is against 2.6.7-rc3-mm2
Signed-off-by: Jesper Juhl <[email protected]>
--- linux-2.6.7-rc3-mm2-orig/arch/i386/kernel/cpu/common.c 2004-06-09 03:34:40.000000000 +0200
+++ linux-2.6.7-rc3-mm2/arch/i386/kernel/cpu/common.c 2004-06-15 23:11:41.000000000 +0200
@@ -338,7 +338,7 @@ void __init identify_cpu(struct cpuinfo_
if (this_cpu->c_identify) {
this_cpu->c_identify(c);
- printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
--
Jesper Juhl <[email protected]>
On Tue, Jun 15, 2004 at 11:21:44PM +0200, Jesper Juhl wrote:
> Visually it's much easier to read/compare messages such as these
>
> Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
>
> if the numbers line up like this
>
> Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
I think it's pointless whilst the third 'after all inits' printk remains
a) unindented and b) interrupted by other blurb, but in all honesty,
I don't think it really matters, so I won't object either way if it goes in.
Dave
On Tue, 15 Jun 2004, Dave Jones wrote:
> On Tue, Jun 15, 2004 at 11:21:44PM +0200, Jesper Juhl wrote:
>
> > Visually it's much easier to read/compare messages such as these
> >
> > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> >
> > if the numbers line up like this
> >
> > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
>
> I think it's pointless whilst the third 'after all inits' printk remains
> a) unindented
Agreed, since only the first two end up in the same log on my system
that's all I'd noticed, but yes, it would make sense to indent the third
as well to make dmesg output look nice as well.
> and b) interrupted by other blurb,
unfortunately, yes, but I'm /not/ going to try and change that :)
>but in all honesty,
> I don't think it really matters, so I won't object either way if it goes in.
>
Ok, thank you for taking a look.
Here's an updated patch that indents the second line a little different
than with the first patch and also indents the "After all ..." line to
match.
Still against 2.6.7-rc3-mm2
Signed-off-by: Jesper Juhl <[email protected]>
--- linux-2.6.7-rc3-mm2-orig/arch/i386/kernel/cpu/common.c 2004-06-09 03:34:40.000000000 +0200
+++ linux-2.6.7-rc3-mm2/arch/i386/kernel/cpu/common.c 2004-06-15 23:39:45.000000000 +0200
@@ -338,7 +338,7 @@ void __init identify_cpu(struct cpuinfo_
if (this_cpu->c_identify) {
this_cpu->c_identify(c);
- printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
@@ -393,7 +393,7 @@ void __init identify_cpu(struct cpuinfo_
/* Now the feature flags better reflect actual CPU features! */
- printk(KERN_DEBUG "CPU: After all inits, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After all inits, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
--
Jesper Juhl <[email protected]>
Jesper Juhl wrote:
> Visually it's much easier to read/compare messages such as these
>
> Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
>
> if the numbers line up like this
>
> Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
>
> /Very/ minor, trivial thing, yes, but those messages have been annoying my
> eyes for a while now so I desided to make them line up - so, here's the
> patch that does that (not sure if a signed-off-by line is needed even for
> trivial stuff like this, but I assume it should go with everything, so...)
> Patch is against 2.6.7-rc3-mm2
>
I think that's what the spaces after CPU: was for... apparently that's gotten
forgotten somehow. Sigh. Please put the extra spaces all in one place.
-hpa
On Tue, 15 Jun 2004, H. Peter Anvin wrote:
> Jesper Juhl wrote:
> > Visually it's much easier to read/compare messages such as these
> >
> > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> >
> > if the numbers line up like this
> >
> > Jun 15 19:09:02 dragon kernel: CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> > Jun 15 19:09:02 dragon kernel: CPU: After vendor identify, caps: 0183f9ff c1c7f9ff 00000000 00000000
> >
> > /Very/ minor, trivial thing, yes, but those messages have been annoying my
> > eyes for a while now so I desided to make them line up - so, here's the
> > patch that does that (not sure if a signed-off-by line is needed even for
> > trivial stuff like this, but I assume it should go with everything, so...)
> > Patch is against 2.6.7-rc3-mm2
> >
>
> I think that's what the spaces after CPU: was for... apparently that's gotten
> forgotten somehow. Sigh. Please put the extra spaces all in one place.
>
Ok, I already send off a second version that indented the third line to
match as well, and had the extra space after "caps:", but here's a (maybe
better) third version that remove the extra spacing after "CPU:" and makes
all the extra spacing appear after "caps:"
still 2.6.7-rc3-mm2 patch
Signed-off-by: Jesper Juhl <[email protected]>
--- linux-2.6.7-rc3-mm2-orig/arch/i386/kernel/cpu/common.c 2004-06-09 03:34:40.000000000 +0200
+++ linux-2.6.7-rc3-mm2/arch/i386/kernel/cpu/common.c 2004-06-15 23:50:33.000000000 +0200
@@ -329,7 +329,7 @@ void __init identify_cpu(struct cpuinfo_
generic_identify(c);
- printk(KERN_DEBUG "CPU: After generic identify, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After generic identify, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
@@ -338,7 +338,7 @@ void __init identify_cpu(struct cpuinfo_
if (this_cpu->c_identify) {
this_cpu->c_identify(c);
- printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After vendor identify, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
@@ -393,7 +393,7 @@ void __init identify_cpu(struct cpuinfo_
/* Now the feature flags better reflect actual CPU features! */
- printk(KERN_DEBUG "CPU: After all inits, caps: %08lx %08lx %08lx %08lx\n",
+ printk(KERN_DEBUG "CPU: After all inits, caps: %08lx %08lx %08lx %08lx\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
--
Jesper Juhl <[email protected]>