2018-06-12 06:51:46

by Zengtao (B)

Subject: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak

In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
a usb request, the current flow will complete one usb request with no
hardware transfer, this will lead to a packet drop on the usb bus.

Signed-off-by: Zeng Tao <[email protected]>
---
drivers/usb/dwc2/gadget.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index f0d9ccf..fbe65f6 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)

tmp = dwc2_hsotg_read_frameno(hsotg);
if (using_desc_dma(hsotg)) {
- dwc2_hsotg_complete_request(hsotg, hs_ep,
- get_ep_head(hs_ep), 0);
-
hs_ep->target_frame = tmp;
dwc2_gadget_incr_frame_num(hs_ep);
dwc2_gadget_start_isoc_ddma(hs_ep);
--
2.7.4

2018-06-12 07:49:16

by Minas Harutyunyan

Subject: Re: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak

Acked-by: Minas Harutyunyan <[email protected]>

On 6/12/2018 10:51 AM, Zeng Tao wrote:
> In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
> a usb request, the current flow will complete one usb request with no
> hardware transfer, this will lead to a packet drop on the usb bus.
>
> Signed-off-by: Zeng Tao <[email protected]>
> ---
> drivers/usb/dwc2/gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f0d9ccf..fbe65f6 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
>
> tmp = dwc2_hsotg_read_frameno(hsotg);
> if (using_desc_dma(hsotg)) {
> - dwc2_hsotg_complete_request(hsotg, hs_ep,
> - get_ep_head(hs_ep), 0);
> -
> hs_ep->target_frame = tmp;
> dwc2_gadget_incr_frame_num(hs_ep);
> dwc2_gadget_start_isoc_ddma(hs_ep);
>