2024-03-07 14:01:08

by André Draszik

Subject: Re: [PATCH] arm64: dts: exynos: gs101: move serial_0 pinctrl-0/names to dtsi

On Thu, 2024-03-07 at 13:52 +0000, Tudor Ambarus wrote:
> The pinctrl nodes are coming from the shared gs101-pinctrl.dtsi,
> thus the pinctrl-0/names shall stay in dtsi. Move them.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---
>  arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 2 --
>  arch/arm64/boot/dts/exynos/google/gs101.dtsi       | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 6ccade2c8cb4..9dc0f47ef646 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -103,8 +103,6 @@ key_power: key-power-pins {
>  };
>  
>  &serial_0 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart0_bus>;
>   status = "okay";
>  };
>  
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..ee65ed9d2cfc 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -421,6 +421,8 @@ serial_0: serial@10a00000 {
>   reg = <0x10a00000 0xc0>;
>   interrupts = <GIC_SPI 634
>         IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_bus>;

The preferred order for these is pinctrl-0 pinctrl-names (and I thought
I had sent a patch for all such issues in gs101, but looks like I
didn't...)

Once addressed:

Reviewed-by: André Draszik <[email protected]>

Cheers,
Andre'

2024-03-08 07:37:59

by Tudor Ambarus

Subject: Re: [PATCH] arm64: dts: exynos: gs101: move serial_0 pinctrl-0/names to dtsi

On 3/7/24 14:00, André Draszik wrote:
> On Thu, 2024-03-07 at 13:52 +0000, Tudor Ambarus wrote:
>> The pinctrl nodes are coming from the shared gs101-pinctrl.dtsi,
>> thus the pinctrl-0/names shall stay in dtsi. Move them.
>>
>> Signed-off-by: Tudor Ambarus <[email protected]>
>> ---
>>  arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 2 --
>>  arch/arm64/boot/dts/exynos/google/gs101.dtsi       | 2 ++
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
>> index 6ccade2c8cb4..9dc0f47ef646 100644
>> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
>> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
>> @@ -103,8 +103,6 @@ key_power: key-power-pins {
>>  };
>>  
>>  &serial_0 {
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&uart0_bus>;
>>   status = "okay";
>>  };
>>  
>> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> index 55e6bcb3689e..ee65ed9d2cfc 100644
>> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> @@ -421,6 +421,8 @@ serial_0: serial@10a00000 {
>>   reg = <0x10a00000 0xc0>;
>>   interrupts = <GIC_SPI 634
>>         IRQ_TYPE_LEVEL_HIGH 0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&uart0_bus>;
>
> The preferred order for these is pinctrl-0 pinctrl-names (and I thought
> I had sent a patch for all such issues in gs101, but looks like I
> didn't...)

Okay, I'll send v2 and change the order in the same patch.

>
> Once addressed:
>
> Reviewed-by: André Draszik <[email protected]>
>
> Cheers,
> Andre'
>