2022-03-24 20:53:19

by Keoseong Park

Subject: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba

Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing
sysfs entries.") removed all code using that field.

Signed-off-by: Keoseong Park <[email protected]>
---
drivers/scsi/ufs/ufshcd.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 88c20f3608c2..94f545be183a 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -820,8 +820,6 @@ struct ufs_hba {
enum ufs_pm_level rpm_lvl;
/* Desired UFS power management level during system PM */
enum ufs_pm_level spm_lvl;
- struct device_attribute rpm_lvl_attr;
- struct device_attribute spm_lvl_attr;
int pm_op_in_progress;

/* Auto-Hibernate Idle Timer register value */
--
2.17.1

2022-03-25 17:41:43

by Bart Van Assche

Subject: Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba

On 3/24/22 00:01, Keoseong Park wrote:
> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba.
> Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing
> sysfs entries.") removed all code using that field.
>
> Signed-off-by: Keoseong Park <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 88c20f3608c2..94f545be183a 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -820,8 +820,6 @@ struct ufs_hba {
> enum ufs_pm_level rpm_lvl;
> /* Desired UFS power management level during system PM */
> enum ufs_pm_level spm_lvl;
> - struct device_attribute rpm_lvl_attr;
> - struct device_attribute spm_lvl_attr;
> int pm_op_in_progress;
>
> /* Auto-Hibernate Idle Timer register value */

Reviewed-by: Bart Van Assche <[email protected]>

2022-03-31 03:45:20

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba

Keoseong,

> Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct
> ufs_hba. Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for
> existing sysfs entries.") removed all code using that field.

Applied to 5.18/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering