2023-11-15 10:01:10

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2] pinctrl: avoid reload of p state in list iteration

Hi Maria,

On Wed, Nov 15, 2023 at 2:13 AM Maria Yu <[email protected]> wrote:

> When in the list_for_each_entry iteration, reload of p->state->settings
> with a local setting from old_state will makes the list iteration in a
> infinite loop.
> The typical issue happened, it will frequently have printk message like:
> "not freeing pin xx (xxx) as part of deactivating group xxx - it is
> already used for some other setting".
> This is a compiler-dependent problem, one instance was got using Clang
> version 10.0 plus arm64 architecture.
>
> Signed-off-by: Maria Yu <[email protected]>
> Cc: [email protected]

Thanks, very much to the point.

Can you please send a v3 and add the info Andy requested too,
and I will apply it!

Yours,
Linus Walleij


2023-11-15 10:32:12

by Aiqun Yu (Maria)

[permalink] [raw]
Subject: Re: [PATCH v2] pinctrl: avoid reload of p state in list iteration

On 11/15/2023 5:58 PM, Linus Walleij wrote:
> Hi Maria,
>
> On Wed, Nov 15, 2023 at 2:13 AM Maria Yu <[email protected]> wrote:
>
>> When in the list_for_each_entry iteration, reload of p->state->settings
>> with a local setting from old_state will makes the list iteration in a
>> infinite loop.
>> The typical issue happened, it will frequently have printk message like:
>> "not freeing pin xx (xxx) as part of deactivating group xxx - it is
>> already used for some other setting".
>> This is a compiler-dependent problem, one instance was got using Clang
>> version 10.0 plus arm64 architecture.
>>
>> Signed-off-by: Maria Yu <[email protected]>
>> Cc: [email protected]
>
> Thanks, very much to the point.
>
> Can you please send a v3 and add the info Andy requested too,
> and I will apply it!
>
> Yours,
> Linus Walleij
Thx Linus Walleij for your quick response.

here it is:
[https://lore.kernel.org/lkml/[email protected]/]

--
Thx and BRs,
Aiqun(Maria) Yu