2018-07-19 20:16:46

by Randy Dunlap

Subject: [PATCH] security: export security_kernel_load_data to fix firmware_loader build

From: Randy Dunlap <[email protected]>

Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:

ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!

Signed-off-by: Randy Dunlap <[email protected]>
Cc: James Morris <[email protected]>
Cc: "Serge E. Hallyn" <[email protected]>
Cc: [email protected]
Cc: Luis R. Rodriguez <[email protected]>
---
security/security.c | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20180717.orig/security/security.c
+++ linux-next-20180717/security/security.c
@@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
return ret;
return ima_load_data(id);
}
+EXPORT_SYMBOL_GPL(security_kernel_load_data);

int security_task_fix_setuid(struct cred *new, const struct cred *old,
int flags)

2018-07-19 22:40:39

by Mimi Zohar

Subject: Re: [PATCH] security: export security_kernel_load_data to fix firmware_loader build

Thanks, Randy.

On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
>
> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: James Morris <[email protected]>
> Cc: "Serge E. Hallyn" <[email protected]>
> Cc: [email protected]
> Cc: Luis R. Rodriguez <[email protected]>
> ---
> security/security.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20180717.orig/security/security.c
> +++ linux-next-20180717/security/security.c
> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
> return ret;
> return ima_load_data(id);
> }
> +EXPORT_SYMBOL_GPL(security_kernel_load_data);

Arnd Bergmann already posted a similar patch, which is now staged in
James' tree.

Mimi

>
> int security_task_fix_setuid(struct cred *new, const struct cred *old,
> int flags)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2018-07-19 22:42:09

by Randy Dunlap

Subject: Re: [PATCH] security: export security_kernel_load_data to fix firmware_loader build

On 07/19/2018 03:39 PM, Mimi Zohar wrote:
> Thanks, Randy.
>
> On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
>> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
>>
>> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: James Morris <[email protected]>
>> Cc: "Serge E. Hallyn" <[email protected]>
>> Cc: [email protected]
>> Cc: Luis R. Rodriguez <[email protected]>
>> ---
>> security/security.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20180717.orig/security/security.c
>> +++ linux-next-20180717/security/security.c
>> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
>> return ret;
>> return ima_load_data(id);
>> }
>> +EXPORT_SYMBOL_GPL(security_kernel_load_data);
>
> Arnd Bergmann already posted a similar patch, which is now staged in
> James' tree.
>
> Mimi

Good. Thanks.

--
~Randy