2019-11-16 03:50:42

by Finn Thain

Subject: [PATCH] NCR5380: Unconditionally clear ICR after do_abort()

When do_abort() succeeds, the target will go to BUS FREE phase and
there will be no connected command. Therefore, that function should
clear the Initiator Command Register before returning. It already does
so in case of NCR5380_poll_politely() failure; do the same for the
other error case too, that is, NCR5380_transfer_pio() failure.

Cc: Michael Schmitz <[email protected]>
Cc: Ondrej Zary <[email protected]>
Reviewed-and-tested-by: Michael Schmitz <[email protected]>
Tested-by: Ondrej Zary <[email protected]>
Signed-off-by: Finn Thain <[email protected]>
---
drivers/scsi/NCR5380.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 3ea2557e7938..f2f7e6e76c07 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1396,7 +1396,7 @@ static void do_reset(struct Scsi_Host *instance)
* MESSAGE OUT phase and sending an ABORT message.
* @instance: relevant scsi host instance
*
- * Returns 0 on success, -1 on failure.
+ * Returns 0 on success, negative error code on failure.
*/

static int do_abort(struct Scsi_Host *instance)
@@ -1421,7 +1421,7 @@ static int do_abort(struct Scsi_Host *instance)

rc = NCR5380_poll_politely(hostdata, STATUS_REG, SR_REQ, SR_REQ, 10 * HZ);
if (rc < 0)
- goto timeout;
+ goto out;

tmp = NCR5380_read(STATUS_REG) & PHASE_MASK;

@@ -1432,7 +1432,7 @@ static int do_abort(struct Scsi_Host *instance)
ICR_BASE | ICR_ASSERT_ATN | ICR_ASSERT_ACK);
rc = NCR5380_poll_politely(hostdata, STATUS_REG, SR_REQ, 0, 3 * HZ);
if (rc < 0)
- goto timeout;
+ goto out;
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE | ICR_ASSERT_ATN);
}

@@ -1441,17 +1441,17 @@ static int do_abort(struct Scsi_Host *instance)
len = 1;
phase = PHASE_MSGOUT;
NCR5380_transfer_pio(instance, &phase, &len, &msgptr);
+ if (len)
+ rc = -ENXIO;

/*
* If we got here, and the command completed successfully,
* we're about to go into bus free state.
*/

- return len ? -1 : 0;
-
-timeout:
+out:
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);
- return -1;
+ return rc;
}

/*
@@ -2283,7 +2283,7 @@ static int NCR5380_abort(struct scsi_cmnd *cmd)
dsprintk(NDEBUG_ABORT, instance, "abort: cmd %p is connected\n", cmd);
hostdata->connected = NULL;
hostdata->dma_len = 0;
- if (do_abort(instance)) {
+ if (do_abort(instance) < 0) {
set_host_byte(cmd, DID_ERROR);
complete_cmd(instance, cmd);
result = FAILED;
--
2.23.0

2019-11-19 04:47:53

by Martin K. Petersen

Subject: Re: [PATCH] NCR5380: Unconditionally clear ICR after do_abort()

Finn,

> When do_abort() succeeds, the target will go to BUS FREE phase and
> there will be no connected command. Therefore, that function should
> clear the Initiator Command Register before returning. It already does
> so in case of NCR5380_poll_politely() failure; do the same for the
> other error case too, that is, NCR5380_transfer_pio() failure.

Applied to 5.5/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering