2019-03-20 14:13:14

by Yue Haibing

Subject: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static

From: YueHaibing <[email protected]>

Fix sparse warning:

drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
symbol 'fusb302_irq_work' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/usb/typec/tcpm/fusb302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index 261b829..457fe7a 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
return IRQ_HANDLED;
}

-void fusb302_irq_work(struct work_struct *work)
+static void fusb302_irq_work(struct work_struct *work)
{
struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
irq_work);
--
2.7.0

2019-03-20 14:59:24

by Guenter Roeck

Subject: Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static

On Wed, Mar 20, 2019 at 10:12:02PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);
> --
> 2.7.0
>
>

2019-03-20 15:04:02

by Heikki Krogerus

Subject: Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static

On Wed, Mar 20, 2019 at 10:12:02PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);

thanks,

--
heikki

2019-03-20 19:26:43

by Mukesh Ojha

Subject: Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static

On 3/20/2019 7:42 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);

Good  to see the work on sparse warning as well.


Acked-by: Mukesh Ojha <[email protected]>

Thanks,
Mukesh

2019-03-20 19:52:55

by Mukesh Ojha

Subject: Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static

On 3/20/2019 7:42 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);


Reviewed-by: Mukesh Ojha <[email protected]>