Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
find this delay make NetworkManager slow to connect.
--- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500
+++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500
@@ -6918,7 +6918,7 @@
/* When we are associated again, the scan has surely finished.
* Just in case, let's make sure enough time has elapsed since
* we started the scan. - Javier */
- if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
+ if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
/* Important note : we don't want to block the caller
* until results are ready for various reasons.
* First, managing wait queues is complex and racy
Signed-off-by: Bill Moss <[email protected]>
Bill Moss wrote:
> Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
> find this delay make NetworkManager slow to connect.
>
> --- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500
> +++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500
> @@ -6918,7 +6918,7 @@
> /* When we are associated again, the scan has surely finished.
> * Just in case, let's make sure enough time has elapsed since
> * we started the scan. - Javier */
> - if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
> + if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
> /* Important note : we don't want to block the caller
> * until results are ready for various reasons.
> * First, managing wait queues is complex and racy
>
> Signed-off-by: Bill Moss <[email protected]>
With this change, the time_before() test can't possibly succeed, can it?
In that case, why not remove the if and its body completely?
Michal