2005-11-13 07:59:31

by Yan Zheng

Subject: [PATCH]small fix for __ipv6_addr_type(...)

Hi.

I think the scope for loopback address should be node local.

Regards

Signed-off-by: Yan Zheng <[email protected]>

========================================================================
--- linux-2.6.15-rc1/net/ipv6/addrconf.c 2005-11-13 12:23:06.000000000 +0800
+++ linux/net/ipv6/addrconf.c 2005-11-13 15:50:03.000000000 +0800
@@ -249,7 +249,7 @@ int __ipv6_addr_type(const struct in6_ad

if (addr->s6_addr32[3] == htonl(0x00000001))
return (IPV6_ADDR_LOOPBACK | IPV6_ADDR_UNICAST |
- IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_LINKLOCAL)); /* addr-select 3.4 */
+ IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_NODELOCAL)); /* addr-select 3.4 */

return (IPV6_ADDR_COMPATv4 | IPV6_ADDR_UNICAST |
IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL)); /* addr-select 3.3 */

2005-11-15 22:20:54

by Vlad Yasevich

Subject: Re: [PATCH]small fix for __ipv6_addr_type(...)

No, according to RFC 4007, loopback is considered a link-local
address.

-vlad

Yan Zheng wrote:
> Hi.
>
> I think the scope for loopback address should be node local.
>
> Regards
>
> Signed-off-by: Yan Zheng <[email protected]>
>
> ========================================================================
> --- linux-2.6.15-rc1/net/ipv6/addrconf.c 2005-11-13
> 12:23:06.000000000 +0800
> +++ linux/net/ipv6/addrconf.c 2005-11-13 15:50:03.000000000 +0800
> @@ -249,7 +249,7 @@ int __ipv6_addr_type(const struct in6_ad
>
> if (addr->s6_addr32[3] == htonl(0x00000001))
> return (IPV6_ADDR_LOOPBACK | IPV6_ADDR_UNICAST |
> -
> IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_LINKLOCAL)); /* addr-select 3.4 */
> +
> IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_NODELOCAL)); /* addr-select 3.4 */
>
> return (IPV6_ADDR_COMPATv4 | IPV6_ADDR_UNICAST |
> IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL)); /*
> addr-select 3.3 */
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2005-11-16 01:10:25

by YOSHIFUJI Hideaki

Subject: Re: [PATCH]small fix for __ipv6_addr_type(...)

In article <[email protected]> (at Tue, 15 Nov 2005 17:20:50 -0500), Vlad Yasevich <[email protected]> says:

> No, according to RFC 4007, loopback is considered a link-local
> address.

Agreed. RFC3484 also explicitly says that loopback is treated as link-local.

--yoshfuji