2019-05-14 16:04:30

by Madhumitha Prabakaran

Subject: [PATCH] Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'

Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'

Signed-off-by: Madhumitha Prabakaran <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
index d1c57edbe2b8..90793c9f9a0f 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
@@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {
u32 port_handle; /* port */
u32 id; /* Parameter ID */
u32 size; /* Parameter size */
- uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
+ u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
};

struct mmal_msg_port_parameter_set_reply {
@@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {
u32 status; /* Status of mmal_port_parameter_get call */
u32 id; /* Parameter ID */
u32 size; /* Parameter size */
- uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
+ u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
};

/* event messages */
--
2.17.1

2019-05-15 10:05:35

by Stefan Wahren

Subject: Re: [PATCH] Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'

Hi Madhumitha,

On 14.05.19 18:02, Madhumitha Prabakaran wrote:
> Fix the warning issued by checkpatch
> Prefer kernel type 'u32' over 'uint32_t'

grepping the sources within vc04_services shows a lot more occurences.

I suggest to fix this style issue at least for the whole camera driver
and name the patch like

staging: bcm2835-camera: prefer kernel types

Regards
Stefan

>
> Signed-off-by: Madhumitha Prabakaran <[email protected]>
> ---
> drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> index d1c57edbe2b8..90793c9f9a0f 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> @@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {
> u32 port_handle; /* port */
> u32 id; /* Parameter ID */
> u32 size; /* Parameter size */
> - uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> + u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> };
>
> struct mmal_msg_port_parameter_set_reply {
> @@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {
> u32 status; /* Status of mmal_port_parameter_get call */
> u32 id; /* Parameter ID */
> u32 size; /* Parameter size */
> - uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> + u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> };
>
> /* event messages */