2017-07-19 15:42:05

by Philipp Zabel

Subject: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control

Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.

No functional changes.

Cc: Ohad Ben-Cohen <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: [email protected]
Signed-off-by: Philipp Zabel <[email protected]>
---
drivers/remoteproc/keystone_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
index 5f776bfd674a0..920fef072b364 100644
--- a/drivers/remoteproc/keystone_remoteproc.c
+++ b/drivers/remoteproc/keystone_remoteproc.c
@@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;

- ksproc->reset = devm_reset_control_get(dev, NULL);
+ ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(ksproc->reset)) {
ret = PTR_ERR(ksproc->reset);
goto free_rproc;
--
2.11.0

2017-07-19 16:59:20

by Suman Anna

Subject: Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control

On 07/19/2017 10:26 AM, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ohad Ben-Cohen <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: [email protected]
> Signed-off-by: Philipp Zabel <[email protected]>

Acked-by: Suman Anna <[email protected]>

> ---
> drivers/remoteproc/keystone_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index 5f776bfd674a0..920fef072b364 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - ksproc->reset = devm_reset_control_get(dev, NULL);
> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(ksproc->reset)) {
> ret = PTR_ERR(ksproc->reset);
> goto free_rproc;
>

2017-08-24 21:59:03

by Suman Anna

Subject: Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control

Hi Bjorn,

On 07/19/2017 11:59 AM, Suman Anna wrote:
> On 07/19/2017 10:26 AM, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Ohad Ben-Cohen <[email protected]>
>> Cc: Bjorn Andersson <[email protected]>
>> Cc: [email protected]
>> Signed-off-by: Philipp Zabel <[email protected]>
>
> Acked-by: Suman Anna <[email protected]>

Can you pick this one and the other 2 related remoteproc patches?
Believe the subsystem maintainers have been picking these up, I see some
of the other related patches in linux-next but not these.

regards
Suman

>
>> ---
>> drivers/remoteproc/keystone_remoteproc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
>> index 5f776bfd674a0..920fef072b364 100644
>> --- a/drivers/remoteproc/keystone_remoteproc.c
>> +++ b/drivers/remoteproc/keystone_remoteproc.c
>> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>> if (ret)
>> goto free_rproc;
>>
>> - ksproc->reset = devm_reset_control_get(dev, NULL);
>> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>> if (IS_ERR(ksproc->reset)) {
>> ret = PTR_ERR(ksproc->reset);
>> goto free_rproc;
>>
>