2021-03-12 13:59:42

by Antonio Terceiro

Subject: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros

These macros introduce nondeterminism in builds, and break reproducible
builds.

Signed-off-by: Antonio Terceiro <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
---
tools/power/x86/intel-speed-select/isst-config.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
index 582feb88eca3..c50c754a656e 100644
--- a/tools/power/x86/intel-speed-select/isst-config.c
+++ b/tools/power/x86/intel-speed-select/isst-config.c
@@ -2791,7 +2791,6 @@ static void usage(void)
static void print_version(void)
{
fprintf(outf, "Version %s\n", version_str);
- fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
exit(0);
}

--
2.30.1

2021-03-12 15:34:33

by srinivas pandruvada

Subject: Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros

On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.

Thanks. I will include this change in my pull request.

-Srinivas

>
> Signed-off-by: Antonio Terceiro <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> ---
> tools/power/x86/intel-speed-select/isst-config.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
> static void print_version(void)
> {
> fprintf(outf, "Version %s\n", version_str);
> - fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
> exit(0);
> }
>