1. Add the RTASE entry in the Kconfig.
2. Add the CONFIG_RTASE entry in the Makefile.
Signed-off-by: Justin Lai <[email protected]>
---
drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++
drivers/net/ethernet/realtek/Makefile | 1 +
2 files changed, 18 insertions(+)
diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig
index 93d9df55b361..57ef924deebd 100644
--- a/drivers/net/ethernet/realtek/Kconfig
+++ b/drivers/net/ethernet/realtek/Kconfig
@@ -113,4 +113,21 @@ config R8169
To compile this driver as a module, choose M here: the module
will be called r8169. This is recommended.
+config RTASE
+ tristate "Realtek Automotive Switch 9054/9068/9072/9075/9068/9071 PCIe Interface support"
+ depends on PCI
+ select CRC32
+ help
+ Say Y here if you have a Realtek Ethernet adapter belonging to
+ the following families:
+ RTL9054 5GBit Ethernet
+ RTL9068 5GBit Ethernet
+ RTL9072 5GBit Ethernet
+ RTL9075 5GBit Ethernet
+ RTL9068 5GBit Ethernet
+ RTL9071 5GBit Ethernet
+
+ To compile this driver as a module, choose M here: the module
+ will be called rtase. This is recommended.
+
endif # NET_VENDOR_REALTEK
diff --git a/drivers/net/ethernet/realtek/Makefile b/drivers/net/ethernet/realtek/Makefile
index 2e1d78b106b0..0c1c16f63e9a 100644
--- a/drivers/net/ethernet/realtek/Makefile
+++ b/drivers/net/ethernet/realtek/Makefile
@@ -8,3 +8,4 @@ obj-$(CONFIG_8139TOO) += 8139too.o
obj-$(CONFIG_ATP) += atp.o
r8169-objs += r8169_main.o r8169_firmware.o r8169_phy_config.o
obj-$(CONFIG_R8169) += r8169.o
+obj-$(CONFIG_RTASE) += rtase/
--
2.34.1
On Thu, Nov 02, 2023 at 11:45:04PM +0800, Justin Lai wrote:
> 1. Add the RTASE entry in the Kconfig.
> 2. Add the CONFIG_RTASE entry in the Makefile.
>
> Signed-off-by: Justin Lai <[email protected]>
> ---
> drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++
> drivers/net/ethernet/realtek/Makefile | 1 +
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig
> index 93d9df55b361..57ef924deebd 100644
> --- a/drivers/net/ethernet/realtek/Kconfig
> +++ b/drivers/net/ethernet/realtek/Kconfig
> @@ -113,4 +113,21 @@ config R8169
> To compile this driver as a module, choose M here: the module
> will be called r8169. This is recommended.
>
> +config RTASE
> + tristate "Realtek Automotive Switch 9054/9068/9072/9075/9068/9071 PCIe Interface support"
> + depends on PCI
> + select CRC32
> + help
> + Say Y here if you have a Realtek Ethernet adapter belonging to
> + the following families:
> + RTL9054 5GBit Ethernet
> + RTL9068 5GBit Ethernet
> + RTL9072 5GBit Ethernet
> + RTL9075 5GBit Ethernet
> + RTL9068 5GBit Ethernet
> + RTL9071 5GBit Ethernet
> +
> + To compile this driver as a module, choose M here: the module
> + will be called rtase. This is recommended.
> +
> endif # NET_VENDOR_REALTEK
> diff --git a/drivers/net/ethernet/realtek/Makefile b/drivers/net/ethernet/realtek/Makefile
> index 2e1d78b106b0..0c1c16f63e9a 100644
> --- a/drivers/net/ethernet/realtek/Makefile
> +++ b/drivers/net/ethernet/realtek/Makefile
> @@ -8,3 +8,4 @@ obj-$(CONFIG_8139TOO) += 8139too.o
> obj-$(CONFIG_ATP) += atp.o
> r8169-objs += r8169_main.o r8169_firmware.o r8169_phy_config.o
> obj-$(CONFIG_R8169) += r8169.o
> +obj-$(CONFIG_RTASE) += rtase/
An allmodconfig on x86_64 fails to build with the series applied up to this
point.
../drivers/net/ethernet/realtek/rtase/rtase_main.c:68:10: fatal error: net/page_pool.h: No such file or directory 68 | #include <net/page_pool.h>
Please also note that, net-next closed, as per the following:
## Form letter - net-next-closed
The merge window for v6.7 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after November 12th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: cr
Hi Justin,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Justin-Lai/net-ethernet-realtek-rtase-Add-pci-table-supported-in-this-module/20231103-032946
base: net-next/main
patch link: https://lore.kernel.org/r/20231102154505.940783-13-justinlai0215%40realtek.com
patch subject: [PATCH net-next v10 12/13] net:ethernet:realtek: Update the Makefile and Kconfig in the realtek folder
config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231106/[email protected]/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/realtek/rtase/rtase_main.c:68:10: fatal error: 'net/page_pool.h' file not found
68 | #include <net/page_pool.h>
| ^~~~~~~~~~~~~~~~~
1 error generated.
vim +68 drivers/net/ethernet/realtek/rtase/rtase_main.c
db2657d0fa3a98 Justin Lai 2023-11-02 @68 #include <net/page_pool.h>
db2657d0fa3a98 Justin Lai 2023-11-02 69 #include <net/pkt_cls.h>
db2657d0fa3a98 Justin Lai 2023-11-02 70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Justin,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Justin-Lai/net-ethernet-realtek-rtase-Add-pci-table-supported-in-this-module/20231103-032946
base: net-next/main
patch link: https://lore.kernel.org/r/20231102154505.940783-13-justinlai0215%40realtek.com
patch subject: [PATCH net-next v10 12/13] net:ethernet:realtek: Update the Makefile and Kconfig in the realtek folder
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231106/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/realtek/rtase/rtase_main.c:68:10: fatal error: net/page_pool.h: No such file or directory
68 | #include <net/page_pool.h>
| ^~~~~~~~~~~~~~~~~
compilation terminated.
vim +68 drivers/net/ethernet/realtek/rtase/rtase_main.c
db2657d0fa3a98 Justin Lai 2023-11-02 @68 #include <net/page_pool.h>
db2657d0fa3a98 Justin Lai 2023-11-02 69 #include <net/pkt_cls.h>
db2657d0fa3a98 Justin Lai 2023-11-02 70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
> -----Original Message-----
> From: Simon Horman <[email protected]>
> Sent: Sunday, November 5, 2023 2:39 AM
> To: Justin Lai <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Ping-Ke Shih <[email protected]>; Larry Chiu
> <[email protected]>
> Subject: Re: [PATCH net-next v10 12/13] net:ethernet:realtek: Update the
> Makefile and Kconfig in the realtek folder
>
>
> External mail.
>
>
>
> On Thu, Nov 02, 2023 at 11:45:04PM +0800, Justin Lai wrote:
> > 1. Add the RTASE entry in the Kconfig.
> > 2. Add the CONFIG_RTASE entry in the Makefile.
> >
> > Signed-off-by: Justin Lai <[email protected]>
> > ---
> > drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++
> > drivers/net/ethernet/realtek/Makefile | 1 +
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/realtek/Kconfig
> > b/drivers/net/ethernet/realtek/Kconfig
> > index 93d9df55b361..57ef924deebd 100644
> > --- a/drivers/net/ethernet/realtek/Kconfig
> > +++ b/drivers/net/ethernet/realtek/Kconfig
> > @@ -113,4 +113,21 @@ config R8169
> > To compile this driver as a module, choose M here: the module
> > will be called r8169. This is recommended.
> >
> > +config RTASE
> > + tristate "Realtek Automotive Switch
> 9054/9068/9072/9075/9068/9071 PCIe Interface support"
> > + depends on PCI
> > + select CRC32
> > + help
> > + Say Y here if you have a Realtek Ethernet adapter belonging to
> > + the following families:
> > + RTL9054 5GBit Ethernet
> > + RTL9068 5GBit Ethernet
> > + RTL9072 5GBit Ethernet
> > + RTL9075 5GBit Ethernet
> > + RTL9068 5GBit Ethernet
> > + RTL9071 5GBit Ethernet
> > +
> > + To compile this driver as a module, choose M here: the module
> > + will be called rtase. This is recommended.
> > +
> > endif # NET_VENDOR_REALTEK
> > diff --git a/drivers/net/ethernet/realtek/Makefile
> > b/drivers/net/ethernet/realtek/Makefile
> > index 2e1d78b106b0..0c1c16f63e9a 100644
> > --- a/drivers/net/ethernet/realtek/Makefile
> > +++ b/drivers/net/ethernet/realtek/Makefile
> > @@ -8,3 +8,4 @@ obj-$(CONFIG_8139TOO) += 8139too.o
> > obj-$(CONFIG_ATP) += atp.o
> > r8169-objs += r8169_main.o r8169_firmware.o r8169_phy_config.o
> > obj-$(CONFIG_R8169) += r8169.o
> > +obj-$(CONFIG_RTASE) += rtase/
>
> An allmodconfig on x86_64 fails to build with the series applied up to this
> point.
>
> ../drivers/net/ethernet/realtek/rtase/rtase_main.c:68:10: fatal error:
> net/page_pool.h: No such file or directory 68 | #include
> <net/page_pool.h>
>
> Please also note that, net-next closed, as per the following:
>
> ## Form letter - net-next-closed
>
> The merge window for v6.7 has begun and therefore net-next is closed for new
> drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
>
> Please repost when net-next reopens after November 12th.
>
> RFC patches sent for review only are obviously welcome at any time.
>
> See:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#devel
> opment-cycle
> --
> pw-bot: cr
Thank you for your reply. I will correct the relevant compiler error and repost it after opening net-next.