2007-11-18 10:15:51

by Geert Uytterhoeven

Subject: [patch 02/13] dio: ARRAY_SIZE() cleanup

From: Alejandro Martinez Ruiz <[email protected]>

dio: ARRAY_SIZE() cleanup

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/dio/dio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -88,7 +88,7 @@ static struct dioname names[] =
#undef DIONAME
#undef DIOFBNAME

-#define NUMNAMES (sizeof(names) / sizeof(struct dioname))
+#define NUMNAMES ARRAY_SIZE(names)

static const char *unknowndioname
= "unknown DIO board -- please email <[email protected]>!";

--
Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2007-11-20 21:57:37

by Richard Knutsson

Subject: Re: [patch 02/13] dio: ARRAY_SIZE() cleanup

Geert Uytterhoeven wrote:

> -#define NUMNAMES (sizeof(names) / sizeof(struct dioname))
> +#define NUMNAMES ARRAY_SIZE(names)

Why not replace NUMNAMES?

/Richard Knutsson

2007-11-21 07:52:43

by Geert Uytterhoeven

Subject: Re: [patch 02/13] dio: ARRAY_SIZE() cleanup

On Tue, 20 Nov 2007, Richard Knutsson wrote:
> Geert Uytterhoeven wrote:
>
> > -#define NUMNAMES (sizeof(names) / sizeof(struct dioname))
> > +#define NUMNAMES ARRAY_SIZE(names)
>
> Why not replace NUMNAMES?

Good idea! Updated patch below.

---

Subject: dio: ARRAY_SIZE() cleanup

From: Alejandro Martinez Ruiz <[email protected]>

dio: ARRAY_SIZE() cleanup

[Geert: eliminate NUMNAMES, as suggested by Richard Knutsson ]

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/dio/dio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -88,8 +88,6 @@ static struct dioname names[] =
#undef DIONAME
#undef DIOFBNAME

-#define NUMNAMES (sizeof(names) / sizeof(struct dioname))
-
static const char *unknowndioname
= "unknown DIO board -- please email <[email protected]>!";

@@ -97,7 +95,7 @@ static const char *dio_getname(int id)
{
/* return pointer to a constant string describing the board with given ID */
unsigned int i;
- for (i = 0; i < NUMNAMES; i++)
+ for (i = 0; i < ARRAY_SIZE(names); i++)
if (names[i].id == id)
return names[i].name;



Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds